pg.ddx.io  pgsql-docs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Bruce Momjian <bruce@momjian.us>
Cc: Jonathan S. Katz <jkatz@postgresql.org>
Cc: David G. Johnston <david.g.johnston@gmail.com>
Cc: splarv@ya.ru
Cc: pgsql-docs@lists.postgresql.org
Subject: Re: 'value' has special behaviour in alter system
Date: Tue, 24 Oct 2023 14:05:53 -0400
Message-ID: <831891.1698170753@sss.pgh.pa.us> (raw)
In-Reply-To: <ZTf50EnaCrfbyWaV@momjian.us>
References: <167105927893.1897.13227723035830709578@wrigleys.postgresql.org>
	<CAKFQuwbefvj25vYz-0KJ-62oCg8-BxAd3PButBZTJ-7PzUcGbQ@mail.gmail.com>
	<f601ac59-16f9-0b75-2831-e212bae7fda5@postgresql.org>
	<3417417.1671124227@sss.pgh.pa.us>
	<ZTf50EnaCrfbyWaV@momjian.us>

Bruce Momjian <bruce@momjian.us> writes:
> I have developed the attached patch to document this.

This seems a little imprecise:

+      Values with non-alphanumeric characters must be quoted.

I think accurate is more like "Values that are neither a number
nor a valid identifier must be quoted."

Also, that para already mentions that the input can be a
comma-separated list when appropriate, so your add-on para seems
partially repetitive.  I think you could just drop the first
sentence of it.

			regards, tom lane





view thread (8+ messages)  latest in thread

Message-ID: <831891.1698170753@sss.pgh.pa.us>
Permalink:  ../831891.1698170753@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/831891.1698170753@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-docs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, bruce@momjian.us, jkatz@postgresql.org, david.g.johnston@gmail.com, splarv@ya.ru, pgsql-docs@lists.postgresql.org
  Subject: Re: 'value' has special behaviour in alter system
  In-Reply-To: <831891.1698170753@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox