From: Jonathan S. Katz <jkatz@postgresql.org>
To: Michael Paquier <michael@paquier.xyz>
To: Liudmila Mantrova <l.mantrova@postgrespro.ru>
Cc: pgsql-docs@lists.postgresql.org
Subject: Re: some grammar fixes for docs
Date: Thu, 16 May 2019 19:36:02 -0400
Message-ID: <8c3041c5-9d37-a310-c884-f38709ffbe65@postgresql.org> (raw)
In-Reply-To: <20190516233253.GB20887@paquier.xyz>
References: <92961161-9b49-e42f-0a72-d5d47e0ed4de@postgrespro.ru>
<20190516233253.GB20887@paquier.xyz>
On 5/16/19 7:32 PM, Michael Paquier wrote:
> On Thu, May 16, 2019 at 05:11:37PM +0300, Liudmila Mantrova wrote:
>> I have noticed imperfect grammar in a couple of sgml files, please consider
>> a small patch (attached).
>
> Thanks, Liudmila for caring about such matters.
>
>> <para>
>> - Transaction which last more than <replaceable>limit</replaceable> milliseconds
>> + Transactions that last more than <replaceable>limit</replaceable> milliseconds
>> are counted and reported separately, as <firstterm>late</firstterm>.
>> </para>
>
> I don't see much of a difference between "which" or "that" in this
> context, and you are right about the plural for "Transactions". Any
> native English speaker around or anybody with an extra opinion?
>
>> <para>
>> Of the two operator classes for type <type>point</type>,
>> <literal>quad_point_ops</literal> is the default. <literal>kd_point_ops</literal>
>> - supports the same operators but uses a different index data structure which
>> + supports the same operators but uses a different index data structure that
>> may offer better performance in some applications.
>> </para>
>
> Same here.
Technically it should be "that" - often you say "which" when one is
speaking, but in writing, in the above cases, "that" is grammatically
correct.
Thanks,
Jonathan
Attachments:
[application/pgp-signature] signature.asc (832B, ../8c3041c5-9d37-a310-c884-f38709ffbe65@postgresql.org/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: jkatz@postgresql.org, michael@paquier.xyz, l.mantrova@postgrespro.ru, pgsql-docs@lists.postgresql.org
Subject: Re: some grammar fixes for docs
In-Reply-To: <8c3041c5-9d37-a310-c884-f38709ffbe65@postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox