pg.ddx.io  pgsql-docs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: MauMau <maumau307@gmail.com>
To: Vik Fearing <vik.fearing@dalibo.com>
To: PG Docs <pgsql-docs@postgresql.org>
Subject: Re: pageinspect forks
Date: Mon, 11 Aug 2014 07:22:09 +0900
Message-ID: <C7973B036D05487FB1A83AA5231E2039@maumau> (raw)
In-Reply-To: <53E7C12F.3020901@dalibo.com>
References: <53D8E0D9.9090300@dalibo.com>
	<510823BF13464AAE872F0C81C194E86C@maumau>
	<53E7C12F.3020901@dalibo.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-docs>

From: "Vik Fearing" <vik.fearing@dalibo.com>
> On 08/10/2014 03:24 PM, MauMau wrote:
>> Could you also improve the doc by changing "table" to "relation" in the
>> description of get_raw_page()?  Having a quick look at the code, it
>> seems that the function can also handle indexes.
>>
>>        table and returns a copy as a <type>bytea</> value.  This allows a
>
>
> Good catch.  I wasn't sure whether using "relation" or "table or index"
> was better, but after a quick test it seems it works for sequences, too,
> so I've gone with "relation".
>
> It doesn't work with views, of course, but it does work with
> materialized views.
>
> Modified patch attached.

Thanks, I marked this as ready for committer.

I think I'll leave it up to you to decide whether you improve the HINT 
message Fujii-san pointed out, which is in src/backend/catalog/catalog.c.

Regards
MauMau





-- 
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs



view thread (8+ messages)  latest in thread

Message-ID: <C7973B036D05487FB1A83AA5231E2039@maumau>
Permalink:  ../C7973B036D05487FB1A83AA5231E2039@maumau/
Also on:    postgresql.org/message-id/C7973B036D05487FB1A83AA5231E2039@maumau

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-docs@postgresql.org
  Cc: maumau307@gmail.com, vik.fearing@dalibo.com
  Subject: Re: pageinspect forks
  In-Reply-To: <C7973B036D05487FB1A83AA5231E2039@maumau>
  References: <53D8E0D9.9090300@dalibo.com> <510823BF13464AAE872F0C81C194E86C@maumau> <53E7C12F.3020901@dalibo.com> <C7973B036D05487FB1A83AA5231E2039@maumau>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox