public inbox for [email protected]  

help / color / mirror / Atom feed

From: MauMau <[email protected]>
To: Vik Fearing <[email protected]>
To: PG Docs <[email protected]>
Subject: Re: pageinspect forks
Date: Mon, 11 Aug 2014 07:22:09 +0900
Message-ID: <C7973B036D05487FB1A83AA5231E2039@maumau> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<510823BF13464AAE872F0C81C194E86C@maumau>
	<[email protected]>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgsql-docs>

From: "Vik Fearing" <[email protected]>
> On 08/10/2014 03:24 PM, MauMau wrote:
>> Could you also improve the doc by changing "table" to "relation" in the
>> description of get_raw_page()?  Having a quick look at the code, it
>> seems that the function can also handle indexes.
>>
>>        table and returns a copy as a <type>bytea</> value.  This allows a
>
>
> Good catch.  I wasn't sure whether using "relation" or "table or index"
> was better, but after a quick test it seems it works for sequences, too,
> so I've gone with "relation".
>
> It doesn't work with views, of course, but it does work with
> materialized views.
>
> Modified patch attached.

Thanks, I marked this as ready for committer.

I think I'll leave it up to you to decide whether you improve the HINT 
message Fujii-san pointed out, which is in src/backend/catalog/catalog.c.

Regards
MauMau





-- 
Sent via pgsql-docs mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs

view thread (8+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: pageinspect forks
  In-Reply-To: <C7973B036D05487FB1A83AA5231E2039@maumau>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox