public inbox for [email protected]  

help / color / mirror / Atom feed

From: David Johnston <[email protected]>
To: Bruce Momjian <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: [9.3] Should we mention "set_config(...)" in 18.1.3 in Server Configuration?
Date: Wed, 10 Sep 2014 20:09:30 -0400
Message-ID: <CAKFQuwZ2-3k2h0Z6YJ0EbZRNVZtVQUAedccQGJ9JFMqSVeJJ1A@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<CAKFQuwbjqT7jHAULPM0YB7x=+qpddH5bYnGmwZ+yVhNBb6SVnQ@mail.gmail.com>
	<CAKFQuwa5d3EUBGwYN1mA6FKO1K7kO+Wci8yM57QNHdEGQ9TJ9g@mail.gmail.com>
	<CAKFQuwbbOZRqmnx-XRyd+viT+MCAH6TVc0yn1aJtG5MdSNAWpA@mail.gmail.com>
	<[email protected]>
	<CAKFQuwbn=wB_rgkJQRvUH+KOGUUPU9Hde3b0cZvSAv=62df95w@mail.gmail.com>
	<[email protected]>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgsql-docs>

On Wed, Sep 10, 2014 at 4:20 PM, Bruce Momjian <[email protected]> wrote:

> On Tue, Sep  9, 2014 at 03:40:45PM -0400, David Johnston wrote:
>
> > "In addition to setting global defaults or attaching" <- add a comma
> after
> > "defaults"
>
> I didn't like this change as it causes too many comma phrases.
>
> Attaches are the changes since yesterday's patch.  The full patch is at:
>
>         ftp://momjian.us/postgresql/mypatches/config.diff
>
>
​At minimum the word "setting" in that paragraph needs to be made plural.
", you can pass settings to <productname>PostgreSQL..."​

​I'm not particularly fond of the overly long preamble burying the "shell
facilities" - and the resultant comma separating the two - but cannot think
of anything better.  Not having the transition makes it too short and curt.
 The proposed second comma helped to at least break it up but it too
doesn't sound all that great.

I'm good for just making the plural fix and calling it a day.

David J.



​

view thread (9+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [9.3] Should we mention "set_config(...)" in 18.1.3 in Server Configuration?
  In-Reply-To: <CAKFQuwZ2-3k2h0Z6YJ0EbZRNVZtVQUAedccQGJ9JFMqSVeJJ1A@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox