public inbox for [email protected]  

help / color / mirror / Atom feed

From: David Johnston <[email protected]>
To: Tom Lane <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: disabling log_rotation_age feature.
Date: Thu, 12 Jun 2014 12:16:07 -0400
Message-ID: <CAKFQuwZTB-kdvZZQgA6jSqyXtkcHdV9fFjSDt0gutnxmGFRnnw@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<CAHGQGwEPVu2T39Zddvh-CubJ9Ghyz4Gf1-JGqqvu5Ja7m5BJ7w@mail.gmail.com>
	<[email protected]>
	<CAKFQuwayss-PaqZ9+vCfc5h-WUKRtf7Lkn20THfWssmv1qa5eA@mail.gmail.com>
	<[email protected]>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgsql-docs>

On Thursday, June 12, 2014, Tom Lane <[email protected]> wrote:

> David G Johnston <[email protected] <javascript:;>> writes:
> > On Thu, Jun 12, 2014 at 10:42 AM, Tom Lane-2 [via PostgreSQL] <
> > [email protected] <javascript:;>> wrote:
> >> I wonder if we should round fractions up instead of down in that logic?
> >> It might be less surprising for those GUCs where zero is special, and
> >> it seems like about a wash for most others.
>
> > ​I think documenting the behavior better,
>
> I don't.  If you have to explain it, it probably needs improvement.


No argument with the philosophy.


>
> > Green field maybe I'd say yes but given that the new behavior could turn
> > features on that are currently off it doesn't seem to be beneficial
> enough
> > to warrant changing.
>
> I don't think that argument holds water either.  We routinely make
> changes that break old postgresql.conf files.  Not in minor updates
> of course, but none of this is material for back-patching.
>

Then I'd pick throwing an error if a floating point value is assigned to a
parameter that is defined to accept integer. I'd rather actually break the
file and not silently redefine its contents.

David J.

view thread (11+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: disabling log_rotation_age feature.
  In-Reply-To: <CAKFQuwZTB-kdvZZQgA6jSqyXtkcHdV9fFjSDt0gutnxmGFRnnw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox