From: Bruce Momjian <bruce@momjian.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Jonathan S. Katz <jkatz@postgresql.org>
Cc: David G. Johnston <david.g.johnston@gmail.com>
Cc: splarv@ya.ru
Cc: pgsql-docs@lists.postgresql.org
Subject: Re: 'value' has special behaviour in alter system
Date: Tue, 24 Oct 2023 14:36:14 -0400
Message-ID: <ZTgOnpx_FQx-aF5g@momjian.us> (raw)
In-Reply-To: <831891.1698170753@sss.pgh.pa.us>
References: <167105927893.1897.13227723035830709578@wrigleys.postgresql.org>
<CAKFQuwbefvj25vYz-0KJ-62oCg8-BxAd3PButBZTJ-7PzUcGbQ@mail.gmail.com>
<f601ac59-16f9-0b75-2831-e212bae7fda5@postgresql.org>
<3417417.1671124227@sss.pgh.pa.us>
<ZTf50EnaCrfbyWaV@momjian.us>
<831891.1698170753@sss.pgh.pa.us>
On Tue, Oct 24, 2023 at 02:05:53PM -0400, Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > I have developed the attached patch to document this.
>
> This seems a little imprecise:
>
> + Values with non-alphanumeric characters must be quoted.
>
> I think accurate is more like "Values that are neither a number
> nor a valid identifier must be quoted."
>
> Also, that para already mentions that the input can be a
> comma-separated list when appropriate, so your add-on para seems
> partially repetitive. I think you could just drop the first
> sentence of it.
Agreed, updated patch attached.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
Only you can decide what is important to you.
Attachments:
[text/x-diff] alter_system.diff (1.5K, ../ZTgOnpx_FQx-aF5g@momjian.us/2-alter_system.diff)
download | inline diff:diff --git a/doc/src/sgml/ref/alter_system.sgml b/doc/src/sgml/ref/alter_system.sgmlindex 6f8bd39eaf..bea5714ba1 100644--- a/doc/src/sgml/ref/alter_system.sgml+++ b/doc/src/sgml/ref/alter_system.sgml@@ -21,7 +21,7 @@ PostgreSQL documentation
<refsynopsisdiv>
<synopsis>
-ALTER SYSTEM SET <replaceable class="parameter">configuration_parameter</replaceable> { TO | = } { <replaceable class="parameter">value</replaceable> | '<replaceable class="parameter">value</replaceable>' | DEFAULT }+ALTER SYSTEM SET <replaceable class="parameter">configuration_parameter</replaceable> { TO | = } { <replaceable class="parameter">value</replaceable> [, ...] | DEFAULT }
ALTER SYSTEM RESET <replaceable class="parameter">configuration_parameter</replaceable>
ALTER SYSTEM RESET ALL
@@ -83,9 +83,17 @@ ALTER SYSTEM RESET ALL
New value of the parameter. Values can be specified as string
constants, identifiers, numbers, or comma-separated lists of
these, as appropriate for the particular parameter.
+ Values that are neither numbers nor valid identifiers must be quoted.
<literal>DEFAULT</literal> can be written to specify removing the
parameter and its value from <filename>postgresql.auto.conf</filename>.
</para>
++ <para>+ For some list-accepting parameters, quoted values will produce+ double-quoted output to preserve whitespace and commas; for others,+ double-quotes must be used inside single-quoted strings to get+ this effect.+ </para>
</listitem>
</varlistentry>
</variablelist>
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: bruce@momjian.us, tgl@sss.pgh.pa.us, jkatz@postgresql.org, david.g.johnston@gmail.com, splarv@ya.ru, pgsql-docs@lists.postgresql.org
Subject: Re: 'value' has special behaviour in alter system
In-Reply-To: <ZTgOnpx_FQx-aF5g@momjian.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox