pg.ddx.io  pgsql-docs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: pgsql-docs@postgresql.org
Subject: The order of columns about WAL activity in pg_stat_statements
Date: Thu, 14 May 2020 00:11:22 +0900
Message-ID: <a6e68c83-0923-afe7-c1f2-5c5843a21687@oss.nttdata.com> (raw)

Hi,

https://www.postgresql.org/docs/devel/pgstatstatements.html

In pg_stat_statements docs, the columns about WAL activity are put
in the table in the order of wal_bytes, wal_records and wal_fpi. But
in the definition of pg_stat_statements view, wal_bytes is put last.
So I think that it's better to reorder those columns in a consistent
with the view definition. Patch attached. Thought?

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

Attachments:


pgss_docs.patch (text/plain, 952B) download
diff --git a/doc/src/sgml/pgstatstatements.sgml b/doc/src/sgml/pgstatstatements.sgml
index b1d5f3d1dc..edacda971f 100644
--- a/doc/src/sgml/pgstatstatements.sgml
+++ b/doc/src/sgml/pgstatstatements.sgml
@@ -264,15 +264,6 @@
       </entry>
      </row>
 
-     <row>
-      <entry><structfield>wal_bytes</structfield></entry>
-      <entry><type>numeric</type></entry>
-      <entry></entry>
-      <entry>
-        Total amount of WAL bytes generated by the statement
-      </entry>
-     </row>
-
      <row>
       <entry><structfield>wal_records</structfield></entry>
       <entry><type>bigint</type></entry>
@@ -291,6 +282,15 @@
       </entry>
      </row>
 
+     <row>
+      <entry><structfield>wal_bytes</structfield></entry>
+      <entry><type>numeric</type></entry>
+      <entry></entry>
+      <entry>
+        Total amount of WAL bytes generated by the statement
+      </entry>
+     </row>
+
     </tbody>
    </tgroup>
   </table>


view thread (3+ messages)  latest in thread

Message-ID: <a6e68c83-0923-afe7-c1f2-5c5843a21687@oss.nttdata.com>
Permalink:  ../a6e68c83-0923-afe7-c1f2-5c5843a21687@oss.nttdata.com/
Also on:    postgresql.org/message-id/a6e68c83-0923-afe7-c1f2-5c5843a21687@oss.nttdata.com

 ·  · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-docs@postgresql.org
  Cc: masao.fujii@oss.nttdata.com
  Subject: Re: The order of columns about WAL activity in pg_stat_statements
  In-Reply-To: <a6e68c83-0923-afe7-c1f2-5c5843a21687@oss.nttdata.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox