From: Ben Tilly <btilly@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Gregory Stark <stark@enterprisedb.com>
Cc: Magnus Hagander <magnus@hagander.net>
Cc: Oleg Bartunov <oleg@sai.msu.su>
Cc: Pavel Stehule <pavel.stehule@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: tsearch filenames unlikes special symbols and numbers
Date: Mon, 3 Sep 2007 16:54:00 -0700
Message-ID: <acc274b30709031654wf337c8fp79c93fea9f1c3328@mail.gmail.com> (raw)
In-Reply-To: <8195.1188828543@sss.pgh.pa.us>
References: <162867790709021328i7771aa9jfe79268bccbf123d@mail.gmail.com>
<Pine.LNX.4.64.0709030113090.2767@sn.sai.msu.ru>
<18259.1188773171@sss.pgh.pa.us>
<87y7foir7t.fsf@oxford.xeocode.com>
<19257.1188777110@sss.pgh.pa.us>
<87tzqci6tp.fsf@oxford.xeocode.com>
<20070903075609.GD21833@svr2.hagander.net>
<1692.1188826039@sss.pgh.pa.us>
<87zm03zwqs.fsf@oxford.xeocode.com>
<8195.1188828543@sss.pgh.pa.us>
On 9/3/07, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Gregory Stark <stark@enterprisedb.com> writes:
> > "Tom Lane" <tgl@sss.pgh.pa.us> writes:
> >> I'm not convinced that . is issue-free. On most if not all versions of Unix,
> >> you are allowed to open a directory as a file and read the filenames it
> >> contains. While I don't say it'd be easy to manage that through
> >> tsearch, there's at least a potential for discovering the filenames
> >> present in . and .. --- how much do we care about that?
>
> > Actually I don't think that's true any more, most file systems on most Unixen
> > do not allow it. However it appears it's still the case for Solaris so it's
> > still a good point.
>
> Actually, now that I've woken up a bit more, it is not a problem as
> long as the tsearch code always appends some kind of file extension
> to what the user gives, such as ".dict". It'll be impossible to name
> "." or ".." with that addition.
I don't know what you're discussing well enough to know if this is
relevant, but what you just said is not always true. If there is any
way to pass arbitrary binary data into your function call, then
someone can pass in a string with nul in it. When that hits the OS
API, your appended .dict won't be seen as part of the filename.
(This is a common security oversight when calling C APIs from
higher-level languages such as Perl. See
http://artofhacking.com/files/phrack/phrack55/P55-07.TXT for more.)
[...]
Cheers,
Ben
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: btilly@gmail.com, tgl@sss.pgh.pa.us, stark@enterprisedb.com, magnus@hagander.net, oleg@sai.msu.su, pavel.stehule@gmail.com, pgsql-hackers@postgresql.org
Subject: Re: tsearch filenames unlikes special symbols and numbers
In-Reply-To: <acc274b30709031654wf337c8fp79c93fea9f1c3328@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox