From: Katsuragi Yuta <katsuragiy@oss.nttdata.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-docs@lists.postgresql.org
Subject: Re: meson doc: Is "-Dtap-tests" a typo?
Date: Wed, 15 Feb 2023 15:28:26 +0900
Message-ID: <f3195e160e49aecf6af02090eea97e46@oss.nttdata.com> (raw)
In-Reply-To: <Y+xjFxRHr9WDFQrw@paquier.xyz>
References: <cff4558e170be78d8fd64ed45edbe1cb@oss.nttdata.com>
<Y+xjFxRHr9WDFQrw@paquier.xyz>
On 2023-02-15 13:44, Michael Paquier wrote:
> On Tue, Feb 14, 2023 at 09:06:13AM +0000, Katsuragi Yuta wrote:
>> The parameter name "-Dtap-tests" in the meson's doc seems to be a
>> typo.
>> I think "-Dtap_tests" is the correct name. Attached patch fixes that.
>>
>> I got an unknown options error by using "-Dtap-tests=enabled".
>> However,
>> meson_options.txt told me the correct name was "-Dtap_tests".
>
> <varlistentry id="configure-tap-tests-meson">
> - <term><option>-Dtap-tests={ auto | enabled | disabled
> }</option></term>
> + <term><option>-Dtap_tests={ auto | enabled | disabled
> }</option></term>
>
> And meson.build refers to the same term, as of "tap_tests":
> # Check whether tap tests are enabled or not
> tap_tests_enabled = false
> tapopt = get_option('tap_tests')
>
> So you are indeed right. Nice catch. Will fix.
> --
> Michael
Thank you!
regards,
--
Katsuragi Yuta
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: katsuragiy@oss.nttdata.com, michael@paquier.xyz, pgsql-docs@lists.postgresql.org
Subject: Re: meson doc: Is "-Dtap-tests" a typo?
In-Reply-To: <f3195e160e49aecf6af02090eea97e46@oss.nttdata.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox