pg.ddx.io pgsql-docs@postgresql.org mailing list archive
help / color / mirror / Atom feedmeson doc: Is "-Dtap-tests" a typo?
3+ messages / 2 participants
[nested] [flat]
* meson doc: Is "-Dtap-tests" a typo?
@ 2023-02-14 09:06 Katsuragi Yuta <katsuragiy@oss.nttdata.com>
0 siblings, 1 reply; 3+ messages in thread
From: Katsuragi Yuta @ 2023-02-14 09:06 UTC (permalink / raw)
To: pgsql-docs@lists.postgresql.org
Hi,
The parameter name "-Dtap-tests" in the meson's doc seems to be a typo.
I think "-Dtap_tests" is the correct name. Attached patch fixes that.
I got an unknown options error by using "-Dtap-tests=enabled". However,
meson_options.txt told me the correct name was "-Dtap_tests".
regards,
--
Katsuragi Yuta
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
Attachments:
[text/x-diff] meson-doc-tap-tests.patch (569B, ../../cff4558e170be78d8fd64ed45edbe1cb@oss.nttdata.com/2-meson-doc-tap-tests.patch)
download | inline diff:
diff --git a/doc/src/sgml/installation.sgml b/doc/src/sgml/installation.sgml
index 6619e69462..aa7c782c3f 100644
--- a/doc/src/sgml/installation.sgml
+++ b/doc/src/sgml/installation.sgml
@@ -3052,7 +3052,7 @@ ninja install
</varlistentry>
<varlistentry id="configure-tap-tests-meson">
- <term><option>-Dtap-tests={ auto | enabled | disabled }</option></term>
+ <term><option>-Dtap_tests={ auto | enabled | disabled }</option></term>
<listitem>
<para>
Enable tests using the Perl TAP tools. Defaults to auto and requires
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: meson doc: Is "-Dtap-tests" a typo?
@ 2023-02-15 04:44 Michael Paquier <michael@paquier.xyz>
parent: Katsuragi Yuta <katsuragiy@oss.nttdata.com>
0 siblings, 1 reply; 3+ messages in thread
From: Michael Paquier @ 2023-02-15 04:44 UTC (permalink / raw)
To: Katsuragi Yuta <katsuragiy@oss.nttdata.com>; +Cc: pgsql-docs@lists.postgresql.org
On Tue, Feb 14, 2023 at 09:06:13AM +0000, Katsuragi Yuta wrote:
> The parameter name "-Dtap-tests" in the meson's doc seems to be a typo.
> I think "-Dtap_tests" is the correct name. Attached patch fixes that.
>
> I got an unknown options error by using "-Dtap-tests=enabled". However,
> meson_options.txt told me the correct name was "-Dtap_tests".
<varlistentry id="configure-tap-tests-meson">
- <term><option>-Dtap-tests={ auto | enabled | disabled }</option></term>
+ <term><option>-Dtap_tests={ auto | enabled | disabled }</option></term>
And meson.build refers to the same term, as of "tap_tests":
# Check whether tap tests are enabled or not
tap_tests_enabled = false
tapopt = get_option('tap_tests')
So you are indeed right. Nice catch. Will fix.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../../Y+xjFxRHr9WDFQrw@paquier.xyz/2-signature.asc)
download
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: meson doc: Is "-Dtap-tests" a typo?
@ 2023-02-15 06:28 Katsuragi Yuta <katsuragiy@oss.nttdata.com>
parent: Michael Paquier <michael@paquier.xyz>
0 siblings, 0 replies; 3+ messages in thread
From: Katsuragi Yuta @ 2023-02-15 06:28 UTC (permalink / raw)
To: Michael Paquier <michael@paquier.xyz>; +Cc: pgsql-docs@lists.postgresql.org
On 2023-02-15 13:44, Michael Paquier wrote:
> On Tue, Feb 14, 2023 at 09:06:13AM +0000, Katsuragi Yuta wrote:
>> The parameter name "-Dtap-tests" in the meson's doc seems to be a
>> typo.
>> I think "-Dtap_tests" is the correct name. Attached patch fixes that.
>>
>> I got an unknown options error by using "-Dtap-tests=enabled".
>> However,
>> meson_options.txt told me the correct name was "-Dtap_tests".
>
> <varlistentry id="configure-tap-tests-meson">
> - <term><option>-Dtap-tests={ auto | enabled | disabled
> }</option></term>
> + <term><option>-Dtap_tests={ auto | enabled | disabled
> }</option></term>
>
> And meson.build refers to the same term, as of "tap_tests":
> # Check whether tap tests are enabled or not
> tap_tests_enabled = false
> tapopt = get_option('tap_tests')
>
> So you are indeed right. Nice catch. Will fix.
> --
> Michael
Thank you!
regards,
--
Katsuragi Yuta
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2023-02-15 06:28 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2023-02-14 09:06 meson doc: Is "-Dtap-tests" a typo? Katsuragi Yuta <katsuragiy@oss.nttdata.com>
2023-02-15 04:44 ` Michael Paquier <michael@paquier.xyz>
2023-02-15 06:28 ` Katsuragi Yuta <katsuragiy@oss.nttdata.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox