From: myungkyu.lim <myungkyu.lim@samsung.com>
To: 'Michael Paquier' <michael@paquier.xyz>
To: 'Masahiko Sawada' <sawada.mshk@gmail.com>
Cc: 'PostgreSQL-development' <pgsql-hackers@postgresql.org>
Cc: woosung.sohn@samsung.com
Cc: don.hong@samsung.com
Subject: RE: [Todo item] Add entry creation timestamp column to pg_stat_replication
Date: Mon, 26 Nov 2018 14:48:39 +0900
Message-ID: <010201d4854b$ae87e510$0b97af30$@samsung.com> (raw)
In-Reply-To: <20181122075321.GJ3369@paquier.xyz>
References: <CGME20181115080226epcas4p1f81c51691d9f12f7fa94c198e84edb3a@epcas4p1.samsung.com>
<007701d47cb9$8f414380$adc3ca80$@samsung.com>
<20181115082748.GG1374@paquier.xyz>
<CAD21AoCgJ4asOa2qP5DQiyzHBJ+Dhhi8Z5kVVokS-R7HxsmtfA@mail.gmail.com>
<20181122075321.GJ3369@paquier.xyz>
On Thu, Nov 15, 2018 at 5:27 PM Michael Paquier <michael@paquier.xyz> wrote:
>> Good point. 'last_reply_send_time' is better.
>> How about just 'reply_time'?
>
>Please note that the original thread has mentioned reply_timestamp as a
>consensus:
So I selected 'reply_time' because 'timestamp' was not used in stat field.
>On Thu, Nov 15, 2018 at 05:33:26PM +0900, Masahiko Sawada wrote:
>> Yeah, I also agree with 'reply_time'. But please also note that we had
>> the discussion when there is not the similar system catalogs and
>> fields. Now that we have them it might be worth to consider to follow
>> the existing name for consistency.
>
>The fields in pg_stat_wal_receiver are named after their respective fields.
>Now if you look at the fields from pg_stat_replication, you have those from
>the standby:
>sent_lsn => Last write-ahead log location sent on this connection write_lsn
>=> Last write-ahead log location written to disk by this standby server
>flush_lsn => Last write-ahead log location flushed to disk by this standby
>server replay_lsn => Last write-ahead log location replayed into the
>database on this standby server
>
>So to keep the brand consistent, reply_time looks like the best choice as
>Sawada-san suggests?
I agree.
The fields naming in pg_stat_replication are some different from other views
fields.
Not used 'last_' or 'latest_' prefix in fields.
Best regards,
Myungkyu, Lim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: myungkyu.lim@samsung.com, michael@paquier.xyz, sawada.mshk@gmail.com, woosung.sohn@samsung.com, don.hong@samsung.com
Subject: RE: [Todo item] Add entry creation timestamp column to pg_stat_replication
In-Reply-To: <010201d4854b$ae87e510$0b97af30$@samsung.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox