pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Jacob Champion <jchampion@timescale.com>
To: Nikolay Shaplov <dhyan@nataraj.su>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: [PATCH] minor reloption regression tests improvement
Date: Tue, 2 Aug 2022 14:26:28 -0700
Message-ID: <02abb1b9-cbbb-c62d-ed05-4db90397fc88@timescale.com> (raw)
In-Reply-To: <CAAWbhmiuRnNo1Xfd2VvbK0-3YrU7bCwnHXTSOpnLiWd9+5cMnA@mail.gmail.com>
References: <4563991.km65PDbjlG@thinkpad-pgpro>
	<165653872847.1152.5920509051824255715.pgcf@coridan.postgresql.org>
	<2590342.64y9vfTr7p@thinkpad-pgpro>
	<12182567.IpiZAh8j0P@thinkpad-pgpro>
	<CAAWbhmiuRnNo1Xfd2VvbK0-3YrU7bCwnHXTSOpnLiWd9+5cMnA@mail.gmail.com>

On 6/30/22 16:16, Jacob Champion wrote:
> [CFM hat] Since you feel strongly about the patch, and we're short on
> time before the commitfest starts, I have re-registered this. That way
> there can be an explicit decision as opposed to a pocket veto by me.

[CFM hat] Okay, with another CF come and gone without review I feel much
more confident about closing this as Returned with Feedback.

[dev hat] Specifically I don't think this patch is reviewable alone; it
needs to be grouped with the functionality change that needed the
additional coverage. That way it'll be much easier for a reviewer to
decide whether 1) it's covering the right spots and 2) it's an overall
useful addition.

That doesn't mean you have to smash it into another commit; it can be a
separate test commit as part of a bigger patchset, and the commit
message can include the motivation for why you wrote the new test.

Thanks,
--Jacob





view thread (9+ messages)  latest in thread

Message-ID: <02abb1b9-cbbb-c62d-ed05-4db90397fc88@timescale.com>
Permalink:  ../02abb1b9-cbbb-c62d-ed05-4db90397fc88@timescale.com/
Also on:    postgresql.org/message-id/02abb1b9-cbbb-c62d-ed05-4db90397fc88@timescale.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-hackers@postgresql.org
  Cc: jchampion@timescale.com, dhyan@nataraj.su
  Subject: Re: [PATCH] minor reloption regression tests improvement
  In-Reply-To: <02abb1b9-cbbb-c62d-ed05-4db90397fc88@timescale.com>
  References: <4563991.km65PDbjlG@thinkpad-pgpro> <165653872847.1152.5920509051824255715.pgcf@coridan.postgresql.org> <2590342.64y9vfTr7p@thinkpad-pgpro> <12182567.IpiZAh8j0P@thinkpad-pgpro> <CAAWbhmiuRnNo1Xfd2VvbK0-3YrU7bCwnHXTSOpnLiWd9+5cMnA@mail.gmail.com> <02abb1b9-cbbb-c62d-ed05-4db90397fc88@timescale.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox