pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Mikhail Kulagin <m.kulagin@postgrespro.ru>
To: 'Jacob Champion' <pchampion@vmware.com>
To: michael@paquier.xyz
Cc: pgsql-hackers@postgresql.org
Subject: RE: [PATCH] Pull general SASL framework out of SCRAM
Date: Tue, 13 Jul 2021 12:41:27 +0300
Message-ID: <05ce01d777cb$40f31d60$c2d95820$@postgrespro.ru> (raw)
In-Reply-To: <5a75d91c1e06cce43ba038ccaa8bfded5cb35df2.camel@vmware.com>
References: <3d2a6f5d50e741117d6baf83eb67ebf1a8a35a11.camel@vmware.com>
	<YNLlBncQGBIAMWho@paquier.xyz>
	<9dc553fe86ba34bff1e0b636c493b527fc7bc030.camel@vmware.com>
	<YNZ5Bqq4GvhNvbp0@paquier.xyz>
	<0907fda41fb40b23e2cbdf7eb05a8d61dd5307b3.camel@vmware.com>
	<YOLAIngluq5wOmgE@paquier.xyz>
	<39a6bd825fd776f5f9c3a8eb7ca1c62f77cea433.camel@vmware.com>
	<YOU2xFL/WoHl6ny0@paquier.xyz>
	<5cf3c71d51a215d4103abcc686c69e79619e7b60.camel@vmware.com>
	<YOao1wTwiWFsgL4p@paquier.xyz>
	<5a75d91c1e06cce43ba038ccaa8bfded5cb35df2.camel@vmware.com>

Hello, hackers!

I got an error while building one of the extensions.
/home/mkulagin/pg-install/postgresql-master/include/internal/libpq-int.h:44:10: fatal error: fe-auth-sasl.h: No such file or directory
                  #include "fe-auth-sasl.h"
                  ^~~~~~~~~~~~~~~~            

I think the new fe-auth-sasl.h file should be installed too.
Correction proposal in the attached file (but I'm not sure that fix of Install.pm is correct).

Regards, Mikhail A. Kulagin
PostgresPro

 

Attachments:


missing_fe-auth-sasl.h.patch (application/octet-stream, 1.4K) download
diff --git a/src/interfaces/libpq/Makefile b/src/interfaces/libpq/Makefile
index 94c3c73e41..61c7dae80b 100644
--- a/src/interfaces/libpq/Makefile
+++ b/src/interfaces/libpq/Makefile
@@ -132,6 +132,7 @@ install: all installdirs install-lib
 	$(INSTALL_DATA) $(srcdir)/libpq-events.h '$(DESTDIR)$(includedir)'
 	$(INSTALL_DATA) $(srcdir)/libpq-int.h '$(DESTDIR)$(includedir_internal)'
 	$(INSTALL_DATA) $(srcdir)/pqexpbuffer.h '$(DESTDIR)$(includedir_internal)'
+	$(INSTALL_DATA) $(srcdir)/fe-auth-sasl.h '$(DESTDIR)$(includedir_internal)'
 	$(INSTALL_DATA) $(srcdir)/pg_service.conf.sample '$(DESTDIR)$(datadir)/pg_service.conf.sample'
 
 installcheck:
@@ -145,6 +146,7 @@ uninstall: uninstall-lib
 	rm -f '$(DESTDIR)$(includedir)/libpq-events.h'
 	rm -f '$(DESTDIR)$(includedir_internal)/libpq-int.h'
 	rm -f '$(DESTDIR)$(includedir_internal)/pqexpbuffer.h'
+	rm -f '$(DESTDIR)$(includedir_internal)/fe-auth-sasl.h'
 	rm -f '$(DESTDIR)$(datadir)/pg_service.conf.sample'
 
 clean distclean: clean-lib
diff --git a/src/tools/msvc/Install.pm b/src/tools/msvc/Install.pm
index de22c9ba2c..3af324e3fa 100644
--- a/src/tools/msvc/Install.pm
+++ b/src/tools/msvc/Install.pm
@@ -633,7 +633,7 @@ sub CopyIncludeFiles
 	CopyFiles(
 		'Libpq internal headers',
 		$target . '/include/internal/',
-		'src/interfaces/libpq/', 'libpq-int.h', 'pqexpbuffer.h');
+		'src/interfaces/libpq/', 'libpq-int.h', 'pqexpbuffer.h', 'fe-auth-sasl.h');
 
 	CopyFiles(
 		'Internal headers',
=

view thread (19+ messages)  latest in thread

Message-ID: <05ce01d777cb$40f31d60$c2d95820$@postgrespro.ru>
Permalink:  ../05ce01d777cb$40f31d60$c2d95820$@postgrespro.ru/
Also on:    postgresql.org/message-id/05ce01d777cb$40f31d60$c2d95820$@postgrespro.ru

 ·  · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: m.kulagin@postgrespro.ru, pchampion@vmware.com, michael@paquier.xyz
  Subject: RE: [PATCH] Pull general SASL framework out of SCRAM
  In-Reply-To: <05ce01d777cb$40f31d60$c2d95820$@postgrespro.ru>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox