pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Review for GetWALAvailability()
Date: Thu, 18 Jun 2020 10:29:27 +0900
Message-ID: <06307e6d-6c5a-d987-2a76-b68a2d8dff8a@oss.nttdata.com> (raw)
In-Reply-To: <20200617180437.GA1812@alvherre.pgsql>
References: <20200617180437.GA1812@alvherre.pgsql>



On 2020/06/18 3:04, Alvaro Herrera wrote:
> I think passing the slot name when the slot is also passed is useless
> and wasteful; it'd be better to pass NULL for the name and ignore the
> strcmp() in that case -- in fact I suggest to forbid passing both name
> and slot.  (Any failure there would risk raising an error during
> checkpoint, which is undesirable.)

Sounds reasonable.

> So I propose the following tweaks to your patch, and otherwise +1.

Thanks for the patch! It looks good to me.

Barring any objections, I will commit the patches in the master and
v13 branches later.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION





view thread (38+ messages)  latest in thread

Message-ID: <06307e6d-6c5a-d987-2a76-b68a2d8dff8a@oss.nttdata.com>
Permalink:  ../06307e6d-6c5a-d987-2a76-b68a2d8dff8a@oss.nttdata.com/
Also on:    postgresql.org/message-id/06307e6d-6c5a-d987-2a76-b68a2d8dff8a@oss.nttdata.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-hackers@postgresql.org
  Cc: masao.fujii@oss.nttdata.com, alvherre@2ndquadrant.com, horikyota.ntt@gmail.com
  Subject: Re: Review for GetWALAvailability()
  In-Reply-To: <06307e6d-6c5a-d987-2a76-b68a2d8dff8a@oss.nttdata.com>
  References: <20200617180437.GA1812@alvherre.pgsql> <06307e6d-6c5a-d987-2a76-b68a2d8dff8a@oss.nttdata.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox