From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: wrong relkind error messages
Date: Thu, 8 Jul 2021 09:54:58 +0200
Message-ID: <08b1063f-5341-c30e-6789-b523dd0e9e29@enterprisedb.com> (raw)
In-Reply-To: <202107021610.fv2n3ehw4yu7@alvherre.pgsql>
References: <202107021610.fv2n3ehw4yu7@alvherre.pgsql>
On 02.07.21 18:10, Alvaro Herrera wrote:
> On 2021-Jun-24, Peter Eisentraut wrote:
>
>> There might be room for some wordsmithing in a few places, but generally I
>> think this is complete.
>
> This looks good to me. I am +0.1 on your proposal of "cannot have
> triggers" vs Michael's "cannot create triggers", but really I could go
> with either. Michael's idea has the disadvantage that if the user fails
> to see the trailing "s" in "triggers" they could get the idea that it's
> possible to create some other trigger; that seems impossible to miss
> with your wording. But it's not that bad either.
>
> It seemed odd to me at first that errdetail_relkind_not_supported()
> returns int, but I realized that it's a trick to let you write "return
> errdetail()" so you don't have to have "break" which would require one
> extra line. Looks fine.
Thanks, committed.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: peter.eisentraut@enterprisedb.com, alvherre@alvh.no-ip.org
Subject: Re: wrong relkind error messages
In-Reply-To: <08b1063f-5341-c30e-6789-b523dd0e9e29@enterprisedb.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox