From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: wrong relkind error messages
Date: Wed, 21 Jul 2021 08:03:29 +0200
Message-ID: <8ff66f7e-d31b-3691-da73-afe20e238f80@enterprisedb.com> (raw)
In-Reply-To: <YPeEo99s6MaQucRl@paquier.xyz>
References: <202107021610.fv2n3ehw4yu7@alvherre.pgsql>
<08b1063f-5341-c30e-6789-b523dd0e9e29@enterprisedb.com>
<c9ba5c6a-4bd5-e12c-1b3c-edbcaedbf392@enterprisedb.com>
<YPeEo99s6MaQucRl@paquier.xyz>
On 21.07.21 04:21, Michael Paquier wrote:
> On Tue, Jul 20, 2021 at 05:08:53PM +0200, Peter Eisentraut wrote:
>> While reviewing the logical decoding of sequences patch, I found a few more
>> places that could be updated in the new style introduced by this thread.
>> See attached patch.
>
> Those changes look fine. I am spotting one instance in
> init_sequence() that looks worth aligning with the others?
I think if you write "ALTER SEQUENCE foo", then "foo is not a sequence"
would be an appropriate error message, so this doesn't need changing.
> Did you consider changing RangeVarCallbackForAlterRelation() or
> ExecGrant_Relation() when it came to this thread? Just noticing that,
> while going through the code.
These might be worth another look, but I'd need to investigate more in
what situations they happen.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: peter.eisentraut@enterprisedb.com, michael@paquier.xyz
Subject: Re: wrong relkind error messages
In-Reply-To: <8ff66f7e-d31b-3691-da73-afe20e238f80@enterprisedb.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox