pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: torikoshia <torikoshia@oss.nttdata.com>
To: Michael Paquier <michael@paquier.xyz>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Allow pg_archivecleanup to remove backup history files
Date: Fri, 9 Jun 2023 00:32:15 +0900
Message-ID: <0e962f8a-78f5-eafe-1d54-7434482e9fd1@oss.nttdata.com> (raw)
In-Reply-To: <be11e1f6f55854c3d5a818dfad819603@oss.nttdata.com>
References: <ZEhIiaCa2rdc/SLb@paquier.xyz>
	<5adce8cd5ad2269fe687d2d56a341c88@oss.nttdata.com>
	<CALj2ACWq=axkHYKkWBAy5_DuuRGXDOhju_2EsexhxpWKZ-fiHg@mail.gmail.com>
	<61abc656edfba4a668b367d590b1aaab@oss.nttdata.com>
	<ZGF6WNGoVcUwi2EF@paquier.xyz>
	<e02ae6b16a32bdd2f4856e9b7f8a6439@oss.nttdata.com>
	<ZGHPsYohfCX+yRb6@paquier.xyz>
	<dea86e6f7224b41266b8a2bded766ca1@oss.nttdata.com>
	<ZG1nq13v411y4TFL@paquier.xyz>
	<0aad03237204efeb7038dafa38c202aa@oss.nttdata.com>
	<ZHBBarvyNq2FY82v@paquier.xyz>
	<be11e1f6f55854c3d5a818dfad819603@oss.nttdata.com>



On 2023/05/31 10:51, torikoshia wrote:
> Update the patch according to the advice.

Thanks for updating the patches! I have small comments regarding 0002 patch.

+       <para>
+         Remove backup history files.

Isn't it better to document clearly which backup history files to be removed? For example, "In addition to removing WAL files, remove backup history files with prefixes logically preceding the oldestkeptwalfile.".


  	printf(_("  -n, --dry-run               dry run, show the names of the files that would be removed\n"));
+	printf(_("  -b, --clean-backup-history  clean up files including backup history files\n"));

Shouldn't -b option be placed in alphabetical order?

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION





view thread (34+ messages)  latest in thread

Message-ID: <0e962f8a-78f5-eafe-1d54-7434482e9fd1@oss.nttdata.com>
Permalink:  ../0e962f8a-78f5-eafe-1d54-7434482e9fd1@oss.nttdata.com/
Also on:    postgresql.org/message-id/0e962f8a-78f5-eafe-1d54-7434482e9fd1@oss.nttdata.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: masao.fujii@oss.nttdata.com, torikoshia@oss.nttdata.com, michael@paquier.xyz, horikyota.ntt@gmail.com, bharath.rupireddyforpostgres@gmail.com
  Subject: Re: Allow pg_archivecleanup to remove backup history files
  In-Reply-To: <0e962f8a-78f5-eafe-1d54-7434482e9fd1@oss.nttdata.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox