pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Euler Taveira <euler@eulerto.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
Cc: Peter Smith <smithpb2250@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Peter Eisentraut <peter@eisentraut.org>
Cc: Euler Taveira <euler.taveira@enterprisedb.com>
Subject: Re: pg_createsubscriber TAP test wrapping makes command options hard to read.
Date: Mon, 20 Jan 2025 20:15:54 -0300
Message-ID: <0f90c5bd-e71f-49ec-ab80-ba2008be5c37@app.fastmail.com> (raw)
In-Reply-To: <3238498.1737413396@sss.pgh.pa.us>
References: <CAHut+PvfaUZQR3rEnj-Dcg_6713Wu4yRdd-yZkkC9NVsARht8A@mail.gmail.com>
	<556792.1733967676@sss.pgh.pa.us>
	<CAHut+Ps6Q+i_3xS6H7ybw3-hx9+2QOuneTJwHArxqxFnKX5+4g@mail.gmail.com>
	<564915.1733971586@sss.pgh.pa.us>
	<CAHut+PvFGytgJT+K_e2x+uWKuVYCBR3HNaNtPKYEkO3YxAwZvw@mail.gmail.com>
	<Z1peKSb8roiDNgRj@paquier.xyz>
	<CAHut+PvYsVhF5k-mYHVEFdpijdgkYRtoeWVxdspxio0ePRpkug@mail.gmail.com>
	<87pllx5cqn.fsf@wibble.ilmari.org>
	<87msh159c3.fsf@wibble.ilmari.org>
	<CAHut+Ptmusd=7SdZ-n0=fu-Y8ut=UaK9nU4Cqk01wxOmio9nkA@mail.gmail.com>
	<87o70143p6.fsf@wibble.ilmari.org>
	<3b6b2595-9822-4e4f-91ee-b6a44dc4b542@app.fastmail.com>
	<3238498.1737413396@sss.pgh.pa.us>

On Mon, Jan 20, 2025, at 7:49 PM, Tom Lane wrote:
> "Euler Taveira" <euler@eulerto.com> writes:
> > It is kind of annoying to keep version 20230309 around to run perltidy. Do we
> > have any other alternatives?
> 
> As it says in src/tools/pgindent/README:
> 
> 2) Install perltidy.  Please be sure it is version 20230309 (older and newer
>    versions make different formatting choices, and we want consistency).
> 
> I don't think anyone is especially wedded to 20230309 in particular,
> but we don't want different developers using different versions and
> coming out with different results.  The whole point of this effort
> is to standardize code layout as best we can, so that would be
> counterproductive.

I can live with that.

> Do you have a strong argument for switching to some other specific
> version of perltidy?
> 

I don't. Let's see if the Dagfinn's patch will maintain more stable formatting
over the years. I tested in a previous version (20220613) after applying the
patch and it didn't suggest changes.


--
Euler Taveira
EDB   https://www.enterprisedb.com/

view thread (43+ messages)  latest in thread

Message-ID: <0f90c5bd-e71f-49ec-ab80-ba2008be5c37@app.fastmail.com>
Permalink:  ../0f90c5bd-e71f-49ec-ab80-ba2008be5c37@app.fastmail.com/
Also on:    postgresql.org/message-id/0f90c5bd-e71f-49ec-ab80-ba2008be5c37@app.fastmail.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: euler@eulerto.com, tgl@sss.pgh.pa.us, ilmari@ilmari.org, smithpb2250@gmail.com, michael@paquier.xyz, pgsql-hackers@lists.postgresql.org, peter@eisentraut.org, euler.taveira@enterprisedb.com
  Subject: Re: pg_createsubscriber TAP test wrapping makes command options hard to read.
  In-Reply-To: <0f90c5bd-e71f-49ec-ab80-ba2008be5c37@app.fastmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox