pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Bruce Momjian <bruce@momjian.us>
Cc: Paul Guo <guopa@vmware.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Brown <michael.brown@discourse.org>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: fdatasync performance problem with large number of DB files
Date: Fri, 19 Mar 2021 16:34:57 +0900
Message-ID: <10b5b192-21e9-bf28-b22e-ab8ebb9e77d1@oss.nttdata.com> (raw)
In-Reply-To: <CA+hUKGKgj+SN6z91nVmOmTv2KYrG7VnAGdTkWdSjbOPghdtooQ@mail.gmail.com>
References: <CA+hUKGLABi5asn5yFXBrAC0d3dGBN8QHvLq=27sa7thCQV4Z1w@mail.gmail.com>
	<823DAB20-5A5E-4F7B-BF8C-D61FA574DEEA@vmware.com>
	<CA+hUKGJi11x6cHJQNeDnLRvk1GMX18DJQaKFqwCOjgeFnbiVKA@mail.gmail.com>
	<76de0e61-a553-6003-aeec-cb35ada791cf@oss.nttdata.com>
	<CA+hUKGJTERHhpAja3KvwF=0qPTgnFB=QPrR=sHmqWKJ2o2mr2Q@mail.gmail.com>
	<52453bfc-40fb-7771-05ee-cbd04b6b9b6e@oss.nttdata.com>
	<4CB921E5-772B-42F9-B14D-D310E709E8F2@vmware.com>
	<CA+hUKGLkoO6i2qoP6u9uKPx8SL4MGzMnT+xQJ+p_x3FggH1Z8A@mail.gmail.com>
	<20210318135411.GB8529@momjian.us>
	<20210318140352.GC8529@momjian.us>
	<3d1086bd-0881-e0a3-9f4f-bda608f07fdb@oss.nttdata.com>
	<CA+hUKGJyjpuqYq60=zhoMWL5cCJKR_V9FaJtoZUv6nJCdtkPVA@mail.gmail.com>
	<CA+hUKG+jOK-0ZbCAiTwPx8_ajfRs9cAgkFf4BodfQiE9G+3n1w@mail.gmail.com>
	<ca3983c4-0fb3-a64f-c533-ddba3e36b177@oss.nttdata.com>
	<cb8dc397-3376-3d2e-4be0-b986a1c17e82@oss.nttdata.com>
	<CA+hUKGKgj+SN6z91nVmOmTv2KYrG7VnAGdTkWdSjbOPghdtooQ@mail.gmail.com>



On 2021/03/19 14:28, Thomas Munro wrote:
> On Fri, Mar 19, 2021 at 3:23 PM Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
>> Thanks for updating the patch! It looks good to me!
>> I have one minor comment for the patch.
>>
>> +               elog(LOG, "could not open %s: %m", path);
>> +               return;
>> +       }
>> +       if (syncfs(fd) < 0)
>> +               elog(LOG, "could not sync filesystem for \"%s\": %m", path);
>>
>> Since these are neither internal errors nor low-level debug messages, ereport() should be used for them rather than elog()? For example,
> 
> Fixed.

Thanks! LGTM.

> I'll let this sit until tomorrow to collect any other feedback or
> objections, and then push the 0001 patch
> (recovery_init_sync_method=syncfs).

Understood.

> On Fri, Mar 19, 2021 at 4:08 PM Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
>> 0002 patch looks good to me. Thanks!
>> I have minor comments.
> 
> Ok, I made the changes you suggested.

Thanks! LGTM.

> Let's see if anyone else would
> like to vote for or against the concept of the 0002 patch
> (recovery_init_sync_method=none).

Agreed. I also want to hear more opinion about the setting "none".

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION





view thread (49+ messages)  latest in thread

Message-ID: <10b5b192-21e9-bf28-b22e-ab8ebb9e77d1@oss.nttdata.com>
Permalink:  ../10b5b192-21e9-bf28-b22e-ab8ebb9e77d1@oss.nttdata.com/
Also on:    postgresql.org/message-id/10b5b192-21e9-bf28-b22e-ab8ebb9e77d1@oss.nttdata.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-hackers@postgresql.org
  Cc: masao.fujii@oss.nttdata.com, thomas.munro@gmail.com, bruce@momjian.us, guopa@vmware.com, tgl@sss.pgh.pa.us, michael.brown@discourse.org
  Subject: Re: fdatasync performance problem with large number of DB files
  In-Reply-To: <10b5b192-21e9-bf28-b22e-ab8ebb9e77d1@oss.nttdata.com>
  References: <CA+hUKGLABi5asn5yFXBrAC0d3dGBN8QHvLq=27sa7thCQV4Z1w@mail.gmail.com> <823DAB20-5A5E-4F7B-BF8C-D61FA574DEEA@vmware.com> <CA+hUKGJi11x6cHJQNeDnLRvk1GMX18DJQaKFqwCOjgeFnbiVKA@mail.gmail.com> <76de0e61-a553-6003-aeec-cb35ada791cf@oss.nttdata.com> <CA+hUKGJTERHhpAja3KvwF=0qPTgnFB=QPrR=sHmqWKJ2o2mr2Q@mail.gmail.com> <52453bfc-40fb-7771-05ee-cbd04b6b9b6e@oss.nttdata.com> <4CB921E5-772B-42F9-B14D-D310E709E8F2@vmware.com> <CA+hUKGLkoO6i2qoP6u9uKPx8SL4MGzMnT+xQJ+p_x3FggH1Z8A@mail.gmail.com> <20210318135411.GB8529@momjian.us> <20210318140352.GC8529@momjian.us> <3d1086bd-0881-e0a3-9f4f-bda608f07fdb@oss.nttdata.com> <CA+hUKGJyjpuqYq60=zhoMWL5cCJKR_V9FaJtoZUv6nJCdtkPVA@mail.gmail.com> <CA+hUKG+jOK-0ZbCAiTwPx8_ajfRs9cAgkFf4BodfQiE9G+3n1w@mail.gmail.com> <ca3983c4-0fb3-a64f-c533-ddba3e36b177@oss.nttdata.com> <cb8dc397-3376-3d2e-4be0-b986a1c17e82@oss.nttdata.com> <CA+hUKGKgj+SN6z91nVmOmTv2KYrG7VnAGdTkWdSjbOPghdtooQ@mail.gmail.com> <10b5b192-21e9-bf28-b22e-ab8ebb9e77d1@oss.nttdata.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox