pg.ddx.io pgsql-hackers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
ReplicationSlotCtl: undefined reference 3+ messages / 2 participants [nested] [flat]
* ReplicationSlotCtl: undefined reference @ 2019-06-11 12:19 Pavlo Golub <pavlo.golub@cybertec.at> 2019-06-13 14:56 ` Re: ReplicationSlotCtl: undefined reference Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 1 reply; 3+ messages in thread From: Pavlo Golub @ 2019-06-11 12:19 UTC (permalink / raw) To: pgsql-hackers; +Cc: Craig Ringer <craig@2ndquadrant.com> Greetings. Trying to build pg extension I've got error: ``` pglogical_monitoring.o:pglogical_monitoring.c:(.rdata$.refptr.ReplicationSlotCtl[.refptr.ReplicationSlotCtl]+0x0): undefined reference to `ReplicationSlotCtl' collect2: error: ld returned 1 exit status ``` But according to https://commitfest.postgresql.org/16/1390/ it should be marked with PGDLLIMPORT. However checking sources there is no this spec (https://github.com/postgres/postgres/blob/fff2a7d7bd09db38e1bafc1303c29b10a9805dc0/src/include/repli...): ``` extern ReplicationSlotCtlData *ReplicationSlotCtl; ``` Am I correct or missing smth? Craig, it supposed to be your proposal about ReplicationSlotCtl and patch. Am I right? -- Kind regards, Pavlo mailto:pavlo.golub@cybertec.at ^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: ReplicationSlotCtl: undefined reference 2019-06-11 12:19 ReplicationSlotCtl: undefined reference Pavlo Golub <pavlo.golub@cybertec.at> @ 2019-06-13 14:56 ` Tom Lane <tgl@sss.pgh.pa.us> 2019-06-13 15:15 ` Re: ReplicationSlotCtl: undefined reference Pavlo Golub <pavlo.golub@cybertec.at> 0 siblings, 1 reply; 3+ messages in thread From: Tom Lane @ 2019-06-13 14:56 UTC (permalink / raw) To: Pavlo Golub <pavlo.golub@cybertec.at>; +Cc: pgsql-hackers; Craig Ringer <craig@2ndquadrant.com> Pavlo Golub <pavlo.golub@cybertec.at> writes: > Trying to build pg extension I've got error: > ``` > pglogical_monitoring.o:pglogical_monitoring.c:(.rdata$.refptr.ReplicationSlotCtl[.refptr.ReplicationSlotCtl]+0x0): undefined reference to `ReplicationSlotCtl' > collect2: error: ld returned 1 exit status > ``` > But according to https://commitfest.postgresql.org/16/1390/ it should > be marked with PGDLLIMPORT. That last bit never actually got pushed, it seems. Done now. regards, tom lane ^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: ReplicationSlotCtl: undefined reference 2019-06-11 12:19 ReplicationSlotCtl: undefined reference Pavlo Golub <pavlo.golub@cybertec.at> 2019-06-13 14:56 ` Re: ReplicationSlotCtl: undefined reference Tom Lane <tgl@sss.pgh.pa.us> @ 2019-06-13 15:15 ` Pavlo Golub <pavlo.golub@cybertec.at> 0 siblings, 0 replies; 3+ messages in thread From: Pavlo Golub @ 2019-06-13 15:15 UTC (permalink / raw) To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: pgsql-hackers; Craig Ringer <craig@2ndquadrant.com> <div dir='auto'><div><br><div class="gmail_extra"><br><div class="gmail_quote">On Jun 13, 2019 17:56, Tom Lane <tgl@sss.pgh.pa.us> wrote:<br type="attribution"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><p dir="ltr">Pavlo Golub <pavlo.golub@cybertec.at> writes: <br> > Trying to build pg extension I've got error: <br> > ``` <br> > pglogical_monitoring.o:pglogical_monitoring.c:(.rdata$.refptr.ReplicationSlotCtl[.refptr.ReplicationSlotCtl]+0x0): undefined reference to `ReplicationSlotCtl' <br> > collect2: error: ld returned 1 exit status <br> > ``` <br> <br> > But according to https://commitfest.postgresql.org/16/1390/ it should <br> > be marked with PGDLLIMPORT. <br> <br> That last bit never actually got pushed, it seems. Done now. <br></p></blockquote></div></div></div><div dir="auto"><br></div><div dir="auto">Thanks Tom. Really appreciate that!</div><div dir="auto"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><p dir="ltr"> <br> regards, tom lane <br> </p> </blockquote></div><br></div></div></div> ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2019-06-13 15:15 UTC | newest] Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2019-06-11 12:19 ReplicationSlotCtl: undefined reference Pavlo Golub <pavlo.golub@cybertec.at> 2019-06-13 14:56 ` Tom Lane <tgl@sss.pgh.pa.us> 2019-06-13 15:15 ` Pavlo Golub <pavlo.golub@cybertec.at>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox