From: Zdenek Kotala <Zdenek.Kotala@Sun.COM>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Guillaume Smet <guillaume.smet@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter_e@gmx.net>
Cc: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: foreign_data test fails with non-C locale
Date: Sat, 24 Jan 2009 12:18:57 +0100
Message-ID: <1232795937.1385.7.camel@localhost> (raw)
In-Reply-To: <497A9F9F.6030600@dunslane.net>
References: <49675B3F.20002@enterprisedb.com>
<49675C87.8070303@dunslane.net>
<49675E4E.1080805@gmx.net>
<49676B8A.8020707@dunslane.net>
<26314.1231518295@sss.pgh.pa.us>
<1d4e0c10901090845h1d647297w68f6f9a70bb757ec@mail.gmail.com>
<49678659.4040904@dunslane.net>
<1232396014.1406.7.camel@localhost>
<497A9F9F.6030600@dunslane.net>
Andrew Dunstan píše v pá 23. 01. 2009 v 23:57 -0500:
>
> Zdenek Kotala wrote:
> > Andrew Dunstan píše v pá 09. 01. 2009 v 12:16 -0500:
> >
> >
> >> Sure, we can easily have buildfarm's initdb step set any locale (and
> >> encoding, for that matter) we like. That's a simple change.
> >>
> >
> > Will be possible to set more locales and run tests without recompilation
> > on all of them? For example I have installed all Solaris'es locales on
> > my animal, but currently it means that I need perform whole cycle for
> > each locale.
> >
>
> I'm working on this. Yes, you will be able to specify a list of locales
> to check. For each locale the following tests will be run:
> installcheck, pl-installcheck, and contrib-installcheck.
thanks
> However, our tests are still a bit short of working across locales.
Yes, they are. Peter cleaned up some of them, but there are still open
issues. And MacOS has broken locale which is different problem.
> PL-check gives the diff below on PLTCL tests under en_US locale. I guess
> the simplest answer is to add an alternative result file.
Yes, I thought about add locale suffix for alternative result file, but
it could be useless overhead.
But some tests can be modified. For example
select * from T_pkey1 order by key1 using @<, key2;
can be rewritten as
select * from T_pkey1 order by key1 using @<, key2::name;
Zdenek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: Zdenek.Kotala@Sun.COM, andrew@dunslane.net, guillaume.smet@gmail.com, tgl@sss.pgh.pa.us, peter_e@gmx.net, heikki.linnakangas@enterprisedb.com
Subject: Re: foreign_data test fails with non-C locale
In-Reply-To: <1232795937.1385.7.camel@localhost>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox