pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Peter Eisentraut <peter_e@gmx.net>
Cc: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: foreign_data test fails with non-C locale
Date: Fri, 09 Jan 2009 11:24:55 -0500
Message-ID: <26314.1231518295@sss.pgh.pa.us> (raw)
In-Reply-To: <49676B8A.8020707@dunslane.net>
References: <49675B3F.20002@enterprisedb.com>
	<49675C87.8070303@dunslane.net>
	<49675E4E.1080805@gmx.net>
	<49676B8A.8020707@dunslane.net>

Andrew Dunstan <andrew@dunslane.net> writes:
> Peter Eisentraut wrote:
>> The regression tests should work just fine in non-C locales.

> It was discussed here at the time, IIRC, and we put in the check 
> precisely because other locales broke the buildfarm. Originally 
> buildfarm just inherited the locale from its environment.

I don't think we are prepared to buy into a general policy that the
regression tests should pass in *any* locale; maintaining a large
number of variant expected-files isn't very practical.  However, the
de facto policy is that we try to keep them passing in locales that
are used by any of the regular developers.  I think it would be useful
to have buildfarm members testing in a few common locales.

			regards, tom lane



view thread (24+ messages)  latest in thread

Message-ID: <26314.1231518295@sss.pgh.pa.us>
Permalink:  ../26314.1231518295@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/26314.1231518295@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andrew@dunslane.net, peter_e@gmx.net, heikki.linnakangas@enterprisedb.com
  Subject: Re: foreign_data test fails with non-C locale
  In-Reply-To: <26314.1231518295@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox