From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: Michael Banck <michael.banck@credativ.de>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: pg_verify_checksums and -fno-strict-aliasing
Date: Sat, 01 Sep 2018 15:32:10 -0400
Message-ID: <12600.1535830330@sss.pgh.pa.us> (raw)
In-Reply-To: <20180901003303.GE5305@paquier.xyz>
References: <1535618100.1286.3.camel@credativ.de>
<alpine.DEB.2.21.1808301325070.32764@lancre>
<7321.1535639966@sss.pgh.pa.us>
<20180830175652.GC15446@paquier.xyz>
<12123.1535672257@sss.pgh.pa.us>
<20180831000600.GI15446@paquier.xyz>
<28226.1535727306@sss.pgh.pa.us>
<21037.1535745351@sss.pgh.pa.us>
<20180831222119.GD5305@paquier.xyz>
<15258.1535759998@sss.pgh.pa.us>
<20180901003303.GE5305@paquier.xyz>
Michael Paquier <michael@paquier.xyz> writes:
> On Fri, Aug 31, 2018 at 07:59:58PM -0400, Tom Lane wrote:
>> The others you mention could be changed, probably, but I didn't
>> bother as they didn't seem performance-critical.
> It is not really critical indeed. There is an argument to change them
> so as other folks get used to it though.
Fair enough. I renamed the types as suggested, changed a few more
places for consistency's sake, and pushed.
There still remain some places where palloc(BLCKSZ) or equivalent is used,
but there's no matching pfree. In a lot of them the buffer is returned
to the caller so there's no choice. It's likely that some are just
leaking the storage transiently and we could convert them to using a
PGAlignedBlock local variable, but I didn't bother trying to do the
analysis.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, michael@paquier.xyz, coelho@cri.ensmp.fr, michael.banck@credativ.de
Subject: Re: pg_verify_checksums and -fno-strict-aliasing
In-Reply-To: <12600.1535830330@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox