From: Tom Lane <tgl@sss.pgh.pa.us>
To: David G. Johnston <david.g.johnston@gmail.com>
Cc: Peter Geoghegan <pg@bowt.ie>
Cc: Vik Fearing <vik.fearing@2ndquadrant.com>
Cc: Andrew Gierth <andrew@tao11.riddles.org.uk>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Fix for FETCH FIRST syntax problems
Date: Sun, 20 May 2018 17:16:45 -0400
Message-ID: <12746.1526851005@sss.pgh.pa.us> (raw)
In-Reply-To: <CAKFQuwbBOmFiEp4npbQPDN9-Qc6Czoi04=H96YnUmLLBD-9VFQ@mail.gmail.com>
References: <877enz476l.fsf@news-spur.riddles.org.uk>
<22981.1526770675@sss.pgh.pa.us>
<03da97fc-9d6b-cbe1-c28f-cee7c1ba5c38@2ndquadrant.com>
<25267.1526773270@sss.pgh.pa.us>
<CAH2-Wz=XCtrYgKy2QhToivePvuSpx3Eteo7TYrzZPsom-w0VdQ@mail.gmail.com>
<CAKFQuwbBOmFiEp4npbQPDN9-Qc6Czoi04=H96YnUmLLBD-9VFQ@mail.gmail.com>
"David G. Johnston" <david.g.johnston@gmail.com> writes:
> The risk here is significantly reduced since the existing user-visible
> behavior is an error which presumably no one is relying upon. Between that
> and being able to conform to the standard syntax for a long-standing
> feature I would say the benefit outweighs the cost and risk.
The risk you're ignoring is that this patch will break something that
*did* work before. Given that the first version did exactly that,
I do not think that risk should be considered negligible. I'm going
to change my vote for back-patching from -0.5 to -1.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, david.g.johnston@gmail.com, pg@bowt.ie, vik.fearing@2ndquadrant.com, andrew@tao11.riddles.org.uk
Subject: Re: Fix for FETCH FIRST syntax problems
In-Reply-To: <12746.1526851005@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox