pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: hlinnaka <hlinnaka@iki.fi>
Subject: Re: SerializeParamList vs machines with strict alignment
Date: Tue, 02 Oct 2018 00:08:06 -0400
Message-ID: <13340.1538453286@sss.pgh.pa.us> (raw)
In-Reply-To: <CAA4eK1KR-v0fDy+3Osb+dok_+qU2WwijkF8WsUmpBrTcJF+o2Q@mail.gmail.com>
References: <11629.1536550032@sss.pgh.pa.us>
	<CAA4eK1JfEc=cqiUiRvUcHYCf=PVEwM_bZ_QiOMHpqGpUMdY8gA@mail.gmail.com>
	<8352.1536586500@sss.pgh.pa.us>
	<CAA4eK1KTsNC--yPBatOiLJriBfGNgb_vmTF40JcEeZPedcL9YA@mail.gmail.com>
	<CAA4eK1KjGVrbMxaoE=tr1uR7mfpVLYui60tO4ANkQQAV+c+Y_A@mail.gmail.com>
	<27748.1538425312@sss.pgh.pa.us>
	<28627.1538426947@sss.pgh.pa.us>
	<CAEepm=1QkD_udoP3sxc_fci7x3PXQu3-Q-E-oempRuciSNp05Q@mail.gmail.com>
	<4694.1538438514@sss.pgh.pa.us>
	<CAA4eK1JYfe-Sxi3RjjBTnf1y1d-TNK+9nt1-cLajBuaXnJM+8A@mail.gmail.com>
	<8134.1538444333@sss.pgh.pa.us>
	<CAA4eK1KFx+942LJSMt9-Z1p5yvmLqoXv78PaOsKYDgTnepTQ-g@mail.gmail.com>
	<12777.1538452350@sss.pgh.pa.us>
	<CAA4eK1KR-v0fDy+3Osb+dok_+qU2WwijkF8WsUmpBrTcJF+o2Q@mail.gmail.com>

Amit Kapila <amit.kapila16@gmail.com> writes:
> On Tue, Oct 2, 2018 at 9:22 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> (I think we could drop the savepoint
>> too, no?)

> One advantage of keeping the savepoint is that we don't need to
> explicitly drop the objects which we have created temporarily for this
> test.

They'll go away anyway at the end of the transaction that the whole
script is wrapped in.  (But it might be worth choosing slightly less
generic object names, to avoid a conflict against other sub-tests
later in that script.)

			regards, tom lane




view thread (26+ messages)  latest in thread

Message-ID: <13340.1538453286@sss.pgh.pa.us>
Permalink:  ../13340.1538453286@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/13340.1538453286@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, amit.kapila16@gmail.com, thomas.munro@enterprisedb.com, pgsql-hackers@lists.postgresql.org, hlinnaka@iki.fi
  Subject: Re: SerializeParamList vs machines with strict alignment
  In-Reply-To: <13340.1538453286@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox