From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Tomas Vondra <tomas.vondra@2ndquadrant.com>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Masahiko Sawada <masahiko.sawada@2ndquadrant.com>
Cc: tsunakawa.takay@fujitsu.com <tsunakawa.takay@fujitsu.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: SLRU statistics
Date: Fri, 1 May 2020 03:02:59 +0900
Message-ID: <f02fd0ec-a240-b5bf-9992-5faf582738f1@oss.nttdata.com> (raw)
In-Reply-To: <20200402004136.wodwftan45mcwggm@development>
References: <20200229122441.ow7gnnqgesmojyc3@development>
<20200229144426.GA32500@alvherre.pgsql>
<20200229205518.xrxo535zgd7cl6no@development>
<20200327004111.md4suoi6u5suv2qe@development>
<20200328002630.2nz5y3dvymqnvxtv@development>
<20200402004136.wodwftan45mcwggm@development>
On 2020/04/02 9:41, Tomas Vondra wrote:
> Hi,
>
> I've pushed this after some minor cleanup and improvements.
+static char *slru_names[] = {"async", "clog", "commit_timestamp",
+ "multixact_offset", "multixact_member",
+ "oldserxid", "pg_xact", "subtrans",
+ "other" /* has to be last */};
When I tried pg_stat_slru, I found that it returns a row for "pg_xact".
But since there is no "pg_xact" slru ("clog" slru exists instead),
"pg_xact" should be removed? Patch attached.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgmlindex 6562cc400b..ba6d8d2123 100644--- a/doc/src/sgml/monitoring.sgml+++ b/doc/src/sgml/monitoring.sgml@@ -3483,7 +3483,7 @@ SELECT pid, wait_event_type, wait_event FROM pg_stat_activity WHERE wait_event i
predefined list (<literal>async</literal>, <literal>clog</literal>,
<literal>commit_timestamp</literal>, <literal>multixact_offset</literal>,
<literal>multixact_member</literal>, <literal>oldserxid</literal>,
- <literal>pg_xact</literal>, <literal>subtrans</literal> and+ <literal>subtrans</literal> and
<literal>other</literal>) resets counters for only that entry.
Names not included in this list are treated as <literal>other</literal>.
</entry>
diff --git a/src/backend/postmaster/pgstat.c b/src/backend/postmaster/pgstat.cindex 50eea2e8a8..2ba3858d31 100644--- a/src/backend/postmaster/pgstat.c+++ b/src/backend/postmaster/pgstat.c@@ -152,7 +152,7 @@ PgStat_MsgBgWriter BgWriterStats;
*/
static char *slru_names[] = {"async", "clog", "commit_timestamp",
"multixact_offset", "multixact_member",
- "oldserxid", "pg_xact", "subtrans",+ "oldserxid", "subtrans",
"other" /* has to be last */};
/* number of elemenents of slru_name array */
Attachments:
[text/plain] remove_pg_xact_from_pg_stat_slru.patch (1.3K, ../f02fd0ec-a240-b5bf-9992-5faf582738f1@oss.nttdata.com/2-remove_pg_xact_from_pg_stat_slru.patch)
download | inline diff:diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgmlindex 6562cc400b..ba6d8d2123 100644--- a/doc/src/sgml/monitoring.sgml+++ b/doc/src/sgml/monitoring.sgml@@ -3483,7 +3483,7 @@ SELECT pid, wait_event_type, wait_event FROM pg_stat_activity WHERE wait_event i
predefined list (<literal>async</literal>, <literal>clog</literal>,
<literal>commit_timestamp</literal>, <literal>multixact_offset</literal>,
<literal>multixact_member</literal>, <literal>oldserxid</literal>,
- <literal>pg_xact</literal>, <literal>subtrans</literal> and+ <literal>subtrans</literal> and
<literal>other</literal>) resets counters for only that entry.
Names not included in this list are treated as <literal>other</literal>.
</entry>
diff --git a/src/backend/postmaster/pgstat.c b/src/backend/postmaster/pgstat.cindex 50eea2e8a8..2ba3858d31 100644--- a/src/backend/postmaster/pgstat.c+++ b/src/backend/postmaster/pgstat.c@@ -152,7 +152,7 @@ PgStat_MsgBgWriter BgWriterStats;
*/
static char *slru_names[] = {"async", "clog", "commit_timestamp",
"multixact_offset", "multixact_member",
- "oldserxid", "pg_xact", "subtrans",+ "oldserxid", "subtrans",
"other" /* has to be last */};
/* number of elemenents of slru_name array */
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: masao.fujii@oss.nttdata.com, tomas.vondra@2ndquadrant.com, alvherre@2ndquadrant.com, masahiko.sawada@2ndquadrant.com, tsunakawa.takay@fujitsu.com
Subject: Re: SLRU statistics
In-Reply-To: <f02fd0ec-a240-b5bf-9992-5faf582738f1@oss.nttdata.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox