From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael.paquier@gmail.com>
Cc: Aleksander Alekseev <a.alekseev@postgrespro.ru>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH] Remove redundant if clause in standbydesc.c
Date: Fri, 23 Sep 2016 10:38:57 -0400
Message-ID: <13887.1474641537@sss.pgh.pa.us> (raw)
In-Reply-To: <CAB7nPqREvpH6Ex5nKYdkPmkP3iVWW1UHo_1KwsP=kR69OF3=aQ@mail.gmail.com>
References: <20160923090814.GB1238@e733>
<CAB7nPqTbAXzCVDpk=jJz9R=C9ZuBsZcjN1m4-Nq4J7t3RMGOkg@mail.gmail.com>
<20160923095431.GD1238@e733>
<CAB7nPqREvpH6Ex5nKYdkPmkP3iVWW1UHo_1KwsP=kR69OF3=aQ@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Michael Paquier <michael.paquier@gmail.com> writes:
> On Fri, Sep 23, 2016 at 6:54 PM, Aleksander Alekseev
> <a.alekseev@postgrespro.ru> wrote:
>>> Very simple small patch - see attachment.
>>>
>>> /* not expected, but print something anyway */
>>> else if (msg->id == SHAREDINVALRELMAP_ID)
>>> - appendStringInfoString(buf, " relmap");
>>> - else if (msg->id == SHAREDINVALRELMAP_ID)
>>> appendStringInfo(buf, " relmap db %u", msg->rm.dbId);
> Not really but my guess is that the two conditions have been left for
> this purpose.
I think it's a pretty obvious copy-and-pasteo.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, michael.paquier@gmail.com, a.alekseev@postgrespro.ru
Subject: Re: [PATCH] Remove redundant if clause in standbydesc.c
In-Reply-To: <13887.1474641537@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox