From: Aleksander Alekseev <a.alekseev@postgrespro.ru>
To: Michael Paquier <michael.paquier@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH] Remove redundant if clause in standbydesc.c
Date: Fri, 23 Sep 2016 12:54:31 +0300
Message-ID: <20160923095431.GD1238@e733> (raw)
In-Reply-To: <CAB7nPqTbAXzCVDpk=jJz9R=C9ZuBsZcjN1m4-Nq4J7t3RMGOkg@mail.gmail.com>
References: <20160923090814.GB1238@e733>
<CAB7nPqTbAXzCVDpk=jJz9R=C9ZuBsZcjN1m4-Nq4J7t3RMGOkg@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
> > Very simple small patch - see attachment.
>
> /* not expected, but print something anyway */
> else if (msg->id == SHAREDINVALRELMAP_ID)
> - appendStringInfoString(buf, " relmap");
> - else if (msg->id == SHAREDINVALRELMAP_ID)
> appendStringInfo(buf, " relmap db %u", msg->rm.dbId);
>
> Looking at inval.c, dbId can be InvalidOid.
Frankly I'm not very familiar with this part of code. InvalidOid is just
zero. Does it create some problem in this case?
--
Best regards,
Aleksander Alekseev
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: a.alekseev@postgrespro.ru, michael.paquier@gmail.com
Subject: Re: [PATCH] Remove redundant if clause in standbydesc.c
In-Reply-To: <20160923095431.GD1238@e733>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox