pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Vik Fearing <vik.fearing@2ndquadrant.com>
To: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Add %x to PROMPT1 and PROMPT2
Date: Wed, 29 Jan 2020 23:51:10 +0100
Message-ID: <13bc9081-2cf8-bf99-bedb-ce70c82bebc8@2ndquadrant.com> (raw)
In-Reply-To: <alpine.DEB.2.21.2001271250190.24374@pseudo>
References: <09502c40-cfe1-bb29-10f9-4b3fa7b2bbb2@2ndquadrant.com>
	<alpine.DEB.2.21.2001261946530.29788@pseudo>
	<e04078e8-ae4a-b09d-896d-5f2f5a042248@2ndquadrant.com>
	<alpine.DEB.2.21.2001271250190.24374@pseudo>

On 29/01/2020 08:25, Fabien COELHO wrote:
> 
> Hello Vik,
> 
>>> Isn't there examples in the documentation which use the default prompts?
>>>
>>> If so, should they be updated accordingly?
>>
>> Good catch!
>> I thought about the documentation but not the examples therein.
>>
>> Updated patch attached.
> 
> Ok.
> 
> Only one transaction prompt example in the whole documentation:-(
> No tests is troubled by the change:-(
> Sigh…
> 
> Patch applies and compiles cleanly, global and psql make check ok.
> 
> Doc build ok.
> 
> Works for me.

Thanks for the review!

Would you mind changing the status in the commitfest app?
https://commitfest.postgresql.org/27/2427/
-- 
Vik Fearing





view thread (23+ messages)  latest in thread

Message-ID: <13bc9081-2cf8-bf99-bedb-ce70c82bebc8@2ndquadrant.com>
Permalink:  ../13bc9081-2cf8-bf99-bedb-ce70c82bebc8@2ndquadrant.com/
Also on:    postgresql.org/message-id/13bc9081-2cf8-bf99-bedb-ce70c82bebc8@2ndquadrant.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: vik.fearing@2ndquadrant.com, coelho@cri.ensmp.fr
  Subject: Re: Add %x to PROMPT1 and PROMPT2
  In-Reply-To: <13bc9081-2cf8-bf99-bedb-ce70c82bebc8@2ndquadrant.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox