From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Ronan Dunklau <ronan.dunklau@aiven.io>
Cc: pgsql-hackers@lists.postgresql.org, Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Subject: Re: Converting contrib SQL functions to new style
Date: Sat, 14 Dec 2024 13:00:00 -0500
Message-ID: <1400205.1734199200@sss.pgh.pa.us> (raw)
In-Reply-To: <ZzV88-6lOrqd1LNU@paquier.xyz>
References: <3395418.1618352794@sss.pgh.pa.us>
<ZywSnWzXskAxSDew@paquier.xyz>
<ZzMSJkiNZhimjXWx@paquier.xyz>
<2345099.ElGaqSPkdT@aivenlaptop>
<ZzV88-6lOrqd1LNU@paquier.xyz>
Michael Paquier <michael@paquier.xyz> writes:
> Doing that step-by-step is better than nothing, hence limiting the use
> of named parameters for only the functions whose body is rewritten is
> fine by me, as a first step, as long as the names are used rather the
> dollar parameter numbers. I'd suggest to do take the bonus step of
> applying the same rule to all the other functions so as everything
> applies with the same extension update in a single major release.
> Perhaps on top of the patches already proposed? There is no need for
> an extra version bump if all that is done in the same development
> cycle.
FWIW, I don't agree at all with doing argument name addition in
this patchset. Certainly that's a fine thing to do, but it's an
independent issue and should be handled in an independent patch.
I see that the cfbot is unhappy because it doesn't understand
that some of the patches have been applied already. I am going
to go ahead and get the earthdistance one done, because we have
a live problem report about that [1]. I'll rebase and repost
the remainder afterwards.
regards, tom lane
[1] https://www.postgresql.org/message-id/flat/6a6439f1-8039-44e2-8fb9-59028f7f2014%40mailbox.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, michael@paquier.xyz, ronan.dunklau@aiven.io, peter.eisentraut@enterprisedb.com
Subject: Re: Converting contrib SQL functions to new style
In-Reply-To: <1400205.1734199200@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox