From: Tom Lane <tgl@sss.pgh.pa.us>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Daniel Verite <daniel@manitou-mail.org>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Cleanup/remove/update references to OID column
Date: Mon, 01 Jul 2019 12:13:11 -0400
Message-ID: <14686.1561997591@sss.pgh.pa.us> (raw)
In-Reply-To: <20190701155932.GA22866@telsasoft.com>
References: <20190408002847.GA904@telsasoft.com>
<da5a314d-f92d-47ef-b005-8451f26de0f2@manitou-mail.org>
<20190410165917.GD10080@telsasoft.com>
<20190418002347.rlqmypv5prlpl2bg@alap3.anarazel.de>
<20190418004219.GJ2854@telsasoft.com>
<20190418005115.r4mat75wvlski3ij@alap3.anarazel.de>
<20190508190557.GD3925@telsasoft.com>
<20190701155932.GA22866@telsasoft.com>
Justin Pryzby <pryzby@telsasoft.com> writes:
> I'm resending this patch, which still seems to be needed.
Yeah, clearly one copy of that text got missed out. Pushed that.
> Also, should this be removed ? Or at leat remove the parenthesized text, since
> non-system tables no longer have OIDs: "(use to avoid output on system tables)"
No, I think that's still fine as-is. Tables still have OIDs, they
just don't *contain* magic OID columns.
> And maybe this (?)
> trace_lock_table (integer)
Hm, the description of that isn't English, at least:
gettext_noop("Sets the OID of the table with unconditionally lock tracing."),
I'm not entirely sure about the point of tracing locks on just one
table, which seems to be what this is for.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, pryzby@telsasoft.com, andres@anarazel.de, daniel@manitou-mail.org, pgsql-hackers@lists.postgresql.org
Subject: Re: Cleanup/remove/update references to OID column
In-Reply-To: <14686.1561997591@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox