From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Remove configure --disable-float4-byval and --disable-float8-byval
Date: Thu, 31 Oct 2019 09:36:30 -0400
Message-ID: <15316.1572528990@sss.pgh.pa.us> (raw)
In-Reply-To: <f3e1e576-2749-bbd7-2d57-3f9dcf75255a@2ndquadrant.com>
References: <f3e1e576-2749-bbd7-2d57-3f9dcf75255a@2ndquadrant.com>
Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> float4 is now always pass-by-value; the pass-by-reference code path is
> completely removed.
I think this is OK.
> float8 and related types are now hardcoded to pass-by-value or
> pass-by-reference depending on whether the build is 64- or 32-bit, as
> was previously also the default.
I'm less happy with doing this. It makes it impossible to test the
pass-by-reference code paths without actually firing up a 32-bit
environment. It'd be fine to document --disable-float8-byval as
a developer-only option (it might be so already), but I don't want
to lose it completely. I fail to see any advantage in getting rid
of it, anyway, since we do still have to maintain both code paths.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, peter.eisentraut@2ndquadrant.com
Subject: Re: Remove configure --disable-float4-byval and --disable-float8-byval
In-Reply-To: <15316.1572528990@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox