pg.ddx.io pgsql-hackers@postgresql.org mailing list archive
help / color / mirror / Atom feedFrom: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Peter Geoghegan <pg@bowt.ie>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Remove configure --disable-float4-byval and --disable-float8-byval
Date: Fri, 13 Dec 2019 11:25:37 -0500
Message-ID: <24414.1576254337@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+TgmobixQ_GgMi9pYED7v-DQDUZa3YE7ksziuSfs0-r8zj0og@mail.gmail.com>
References: <f3e1e576-2749-bbd7-2d57-3f9dcf75255a@2ndquadrant.com>
<15316.1572528990@sss.pgh.pa.us>
<CA+TgmoaCyw26S7wkTshAJKpjP5zfVnLiBSWYYvn5kT7rh3vrZg@mail.gmail.com>
<CAH2-Wzn1tb8cVoo_E4Tn6CC79ashORQVEteZXMjKnzaz_VmgJQ@mail.gmail.com>
<15314.1572631210@sss.pgh.pa.us>
<CAH2-WznBeqqPJgbjg3rHjCt9B2O0B1iXxR9snyjXJTYK44rEJA@mail.gmail.com>
<CA+TgmoZxtMU-RKtW-Du5RXd33=THxjWNtDj434uNtaAQYAMWOQ@mail.gmail.com>
<CAH2-Wzm4VDS7oq8Wxe--5zpnD3pv+6ED8jcoB3UGJ36ByavjmA@mail.gmail.com>
<80f6bf80-8def-1a48-bd91-c656cc0464e1@2ndquadrant.com>
<CA+TgmobixQ_GgMi9pYED7v-DQDUZa3YE7ksziuSfs0-r8zj0og@mail.gmail.com>
Robert Haas <robertmhaas@gmail.com> writes:
> Well, again, I think the proposal here is not get rid of 32-bit
> support, but to have less code that only gets regularly tested on
> 32-bit machines.
That seems like generally a good plan. But as to the specific idea...
> If we made datums 8 bytes everywhere, we would have
> less such code, and very likely fewer bugs.
... it's not entirely clear to me that it'd be possible to do this
without causing a storm of "cast from pointer to integer of different
size" (and vice versa) warnings on 32-bit machines. That would be a
deal-breaker independently of any performance considerations, IMO.
So if anyone wants to pursue this, finding a way around that might be
the first thing to look at.
regards, tom lane
view thread (26+ messages)
Message-ID: <24414.1576254337@sss.pgh.pa.us>
Permalink: ../24414.1576254337@sss.pgh.pa.us/
Also on: postgresql.org/message-id/24414.1576254337@sss.pgh.pa.us
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, robertmhaas@gmail.com, peter.eisentraut@2ndquadrant.com, pg@bowt.ie
Subject: Re: Remove configure --disable-float4-byval and --disable-float8-byval
In-Reply-To: <24414.1576254337@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox