pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Jacob Champion <pchampion@vmware.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: SSL SNI
Date: Thu, 03 Jun 2021 14:14:41 -0400
Message-ID: <15936.1622744081@sss.pgh.pa.us> (raw)
In-Reply-To: <14840.1622742761@sss.pgh.pa.us>
References: <7289d5eb-62a5-a732-c3b9-438cee2cb709@enterprisedb.com>
	<ef3d4b460ae7da59a8811f4e8e8fde0cd38a6cc8.camel@vmware.com>
	<9407b344-7342-b2b7-004f-d5250687be42@enterprisedb.com>
	<ecb6a57d176a396feb959fbb0c53b3c794e8d8e5.camel@vmware.com>
	<4eaa2b56-c3d0-67b6-4716-010d001c7601@enterprisedb.com>
	<4bf3ae1c-b28e-8960-e89f-c390c5cf01a2@enterprisedb.com>
	<504c276ab6eee000bb23d571ea9b0ced4250774e.camel@vmware.com>
	<14368.1622742108@sss.pgh.pa.us>
	<14840.1622742761@sss.pgh.pa.us>

I wrote:
> It looks like the immediate problem can be resolved by just adding
> a check for conn->pghost not being NULL,

... scratch that.  There's another problem here, which is that this
code should not be looking at conn->pghost AT ALL.  That will do the
wrong thing with a multi-element host list.  The right thing to be
looking at is conn->connhost[conn->whichhost].host --- with a test
to make sure it's not NULL or an empty string.  (I didn't stop to
study this code close enough to see if it'll ignore an empty
string without help.)

			regards, tom lane

view thread (24+ messages)  latest in thread

Message-ID: <15936.1622744081@sss.pgh.pa.us>
Permalink:  ../15936.1622744081@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/15936.1622744081@sss.pgh.pa.us

copy link · copy postgr.es

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, peter.eisentraut@enterprisedb.com, pchampion@vmware.com
  Subject: Re: SSL SNI
  In-Reply-To: <15936.1622744081@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox