From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: Noah Misch <noah@leadboat.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: "debug_invalidate_system_caches_always" is too long
Date: Tue, 06 Jul 2021 09:24:28 -0400
Message-ID: <1664806.1625577868@sss.pgh.pa.us> (raw)
In-Reply-To: <5f1332ab-d2ee-e31d-ecf7-62cc7d150b09@dunslane.net>
References: <1374320.1625430433@sss.pgh.pa.us>
<20210704211234.GD2421985@rfd.leadboat.com>
<1492832.1625512421@sss.pgh.pa.us>
<CALj2ACVT4ga=RDYsBzLg3DXg2ENat2V-eh4yw8oH65Z1CNkJ6g@mail.gmail.com>
<5f1332ab-d2ee-e31d-ecf7-62cc7d150b09@dunslane.net>
Andrew Dunstan <andrew@dunslane.net> writes:
> On 7/5/21 11:46 PM, Bharath Rupireddy wrote:
>> On Tue, Jul 6, 2021 at 12:43 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>> I like "debug_flush_caches" --- it's short and accurate.
>> Do we always flush the cache entries into the disk? Sometimes we just
>> invalidate the cache entries in the registered invalidation callbacks,
>> right? Since we already use the term "clobber" in the user visible
>> config option --clobber-cache, isn't it consistent to use
>> debug_clobber_caches?
> I think 'flush' here means simply 'discard'. Maybe that would be a
> better word to use.
"Discard" could be misinterpreted too, no doubt. None of these words
have one single exact meaning, so I have only limited patience for
this sort of argumentation.
(As for initdb's "--clobber-cache", I'm assuming we'd rename that to
match whatever we come up with here. It is what it is now only because
I was unwilling to call it "--use-debug-invalidate-system-caches-always".)
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, andrew@dunslane.net, bharath.rupireddyforpostgres@gmail.com, noah@leadboat.com, pgsql-hackers@lists.postgresql.org
Subject: Re: "debug_invalidate_system_caches_always" is too long
In-Reply-To: <1664806.1625577868@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox