pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Victor Drobny <v.drobny@postgrespro.ru>
Cc: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: Aleksander Alekseev <a.alekseev@postgrespro.ru>
Cc: Pgsql Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Red-Black tree traversal tests
Date: Sun, 10 Sep 2017 13:32:22 -0400
Message-ID: <16674.1505064742@sss.pgh.pa.us> (raw)
In-Reply-To: <17021.1505002020@sss.pgh.pa.us>
References: <c9d61310e16e75f8acaf6cb1c48b7b77@postgrespro.ru>
	<20170801095446.GA22764@e733.localdomain>
	<20170801095835.GB22764@e733.localdomain>
	<2e864bd9888f41f7f6c9808ee2b8a5a0@postgrespro.ru>
	<419a79bae64398144716c38b85359539@postgrespro.ru>
	<20170803084222.GA14690@e733.localdomain>
	<2479.1504737491@sss.pgh.pa.us>
	<f0c91f2292d8464c29be7f81e55d179d@postgrespro.ru>
	<CAEepm=0BJGpdYN82dze-iGHf4FFWrK9M5kD0uin0Z2kXdw=_UA@mail.gmail.com>
	<b3648015b3440a5dc1d9ffc1b32c1b93@postgrespro.ru>
	<17021.1505002020@sss.pgh.pa.us>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

I wrote:
> In the meantime, here's my version.  Notable changes:

I went ahead and pushed this, with the removal of the preorder/postorder
code, so we can see if the buildfarm finds out anything interesting.
Feel free to continue to submit improvements though.

One thing that occurred to me is that as-is, this is entirely black-box
testing.  It doesn't try to check that the tree actually satisfies the
RB invariants, which is something that is interesting for performance
reasons.  (That is, the code could pass these tests even though it
produces an unbalanced tree with horrible performance.)  Is it worth
adding logic for that?  Not sure.  It's not like we are actively
changing the RB code or have reason to think it is buggy.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (12+ messages)

Message-ID: <16674.1505064742@sss.pgh.pa.us>
Permalink:  ../16674.1505064742@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/16674.1505064742@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, v.drobny@postgrespro.ru, thomas.munro@enterprisedb.com, a.alekseev@postgrespro.ru
  Subject: Re: Red-Black tree traversal tests
  In-Reply-To: <16674.1505064742@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox