From: Victor Drobny <v.drobny@postgrespro.ru>
To: Aleksander Alekseev <a.alekseev@postgrespro.ru>
Cc: Pgsql Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Red-Black tree traversal tests
Date: Wed, 02 Aug 2017 15:13:04 +0300
Message-ID: <2e864bd9888f41f7f6c9808ee2b8a5a0@postgrespro.ru> (raw)
In-Reply-To: <20170801095835.GB22764@e733.localdomain>
References: <c9d61310e16e75f8acaf6cb1c48b7b77@postgrespro.ru>
<20170801095446.GA22764@e733.localdomain>
<20170801095835.GB22764@e733.localdomain>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Hello,
Thank you for the reviewing.
>> If it's not too much trouble perhaps you could write a few more test
>> so
>> we would have 100% test coverage for rbtree, could modify it safely
>> and
>> be sure that it actually works when someone will need the rest of its
>> functionality?
Done. Now all of the functions in rbtree.c are covered.
> Also I would recommend to add your patch to the nearest commitfest [1].
> Otherwise there is a good chance that everyone will forget about it
> quite soon.
>
> [1]: https://commitfest.postgresql.org/14/
Done. Here is the link: https://commitfest.postgresql.org/14/1225/
Thank you for attention!
--
------
Victor Drobny
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: v.drobny@postgrespro.ru, a.alekseev@postgrespro.ru
Subject: Re: Red-Black tree traversal tests
In-Reply-To: <2e864bd9888f41f7f6c9808ee2b8a5a0@postgrespro.ru>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox