public inbox for [email protected]  

help / color / mirror / Atom feed

From: Tom Lane <[email protected]>
To: John Naylor <[email protected]>
Cc: solaimurugan vellaipandiyan <[email protected]>
Cc: Aleksander Alekseev <[email protected]>
Cc: Payal Singh <[email protected]>
Cc: [email protected]
Subject: Re: Review - Patch for pg_bsd_indent: improve formatting of multiline comments
Date: Mon, 11 May 2026 01:04:54 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <CANWCAZbY43YfBVrsVwSafcxe4YdoaAwP1Keu9shcYA6GA=vnLQ@mail.gmail.com>
References: <[email protected]>
	<CAHEL7KRa-rmSCvREEYrdsY97PNgJtqLYfOikfZWEK4enNQhM0Q@mail.gmail.com>
	<[email protected]>
	<CANWCAZbY43YfBVrsVwSafcxe4YdoaAwP1Keu9shcYA6GA=vnLQ@mail.gmail.com>

John Naylor <[email protected]> writes:
> On Mon, May 11, 2026 at 6:37 AM Tom Lane <[email protected]> wrote:
>> I think those are pretty much all improvements, except that it kind
>> of messes up Martin Utesch's ASCII-art signatures in the geqo files.

> Agreed, although this one now seems to use even more vertical space
> that doesn't contain anything:

> -/* Function works as follows:
> +/*
> + * Function works as follows:
> + *
>   *
>   *
> - * */
> + */

Yeah ... what's actually happening there is that it's replacing

 * */

with

 *
 */

although the diff misattributes the extra line.  There are few
enough of those that I didn't think it was worth getting
excited about ...

			regards, tom lane

view thread (11+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Review - Patch for pg_bsd_indent: improve formatting of multiline comments
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox