From: Cédric Villemain <cedric@2ndquadrant.com>
To: pgsql-hackers@postgresql.org
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: Josh Berkus <josh@agliodbs.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Peter Eisentraut <peter_e@gmx.net>
Cc: Craig Ringer <craig@2ndquadrant.com>
Subject: Re: Bugfix and new feature for PGXS
Date: Tue, 03 Sep 2013 10:04:06 +0200
Message-ID: <1739933.FyLmpy7Q73@obelix> (raw)
In-Reply-To: <201307122350.23726.cedric@2ndquadrant.com>
References: <201306181552.36673.cedric@2ndquadrant.com>
<51DB171F.2090108@dunslane.net>
<201307122350.23726.cedric@2ndquadrant.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
> Simple one, attached.
> I didn't document USE_VPATH, not sure how to explain that clearly.
Just a remember that the doc is written and is waiting to be commited.
There is also an issue spoted by Christoph with the installdirs prerequisite,
the attached patch fix that.
Also, the bugfixes were supposed to be backported. The behavior is not changed,
nothing new, just fixing problem for some kind of extension builds. (However
the USE_VPATH is new and is not needed in <9.3)
--
Cédric Villemain +33 (0)6 20 30 22 52
http://2ndQuadrant.fr/
PostgreSQL: Support 24x7 - Développement, Expertise et Formation
Attachments:
[text/x-patch] 0001-Add-installdirs-to-PGXS-order-only-prerequisites.patch (1.0K, ../1739933.FyLmpy7Q73@obelix/2-0001-Add-installdirs-to-PGXS-order-only-prerequisites.patch)
download | inline diff:
From fb9d5ed99397b40e7fc33224fa31cd5c54c7b5d2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?C=C3=A9dric=20Villemain?= <cedric@2ndquadrant.fr>
Date: Tue, 3 Sep 2013 09:55:05 +0200
Subject: [PATCH] Add installdirs to PGXS order-only-prerequisites
prerequisites are not ordered but installdirs is required by others.
This patch is the simplest one, another solution being to remove completely
installdirs prerequisite.
Spotted by Christoph Berg with plr build.
---
src/makefiles/pgxs.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/makefiles/pgxs.mk b/src/makefiles/pgxs.mkindex 8618aa1..ac12f7d 100644--- a/src/makefiles/pgxs.mk+++ b/src/makefiles/pgxs.mk@@ -124,7 +124,7 @@ all: all-lib
endif # MODULE_big
-install: all installdirs installcontrol installdata installdatatsearch installdocs installscripts+install: all installcontrol installdata installdatatsearch installdocs installscripts | installdirs
ifdef MODULES
$(INSTALL_SHLIB) $(addsuffix $(DLSUFFIX), $(MODULES)) '$(DESTDIR)$(pkglibdir)/'
endif # MODULES
--
1.8.4.rc3
[application/pgp-signature] signature.asc (489B, ../1739933.FyLmpy7Q73@obelix/3-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: cedric@2ndquadrant.com, andrew@dunslane.net, josh@agliodbs.com, robertmhaas@gmail.com, peter_e@gmx.net, craig@2ndquadrant.com
Subject: Re: Bugfix and new feature for PGXS
In-Reply-To: <1739933.FyLmpy7Q73@obelix>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox