From: Tom Lane <tgl@sss.pgh.pa.us>
To: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
Cc: Andres Freund <andres@anarazel.de>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Splitting up guc.c
Date: Mon, 12 Sep 2022 16:20:26 -0400
Message-ID: <1778776.1663014026@sss.pgh.pa.us> (raw)
In-Reply-To: <87v8psl5d8.fsf@wibble.ilmari.org>
References: <587607.1662836699@sss.pgh.pa.us>
<Yx0vHEBXwcUggZYK@paquier.xyz>
<666417.1662862120@sss.pgh.pa.us>
<925946.1662918775@sss.pgh.pa.us>
<1305798.1662935501@sss.pgh.pa.us>
<20220912193928.wgrccx4b4k3solpu@awork3.anarazel.de>
<1771845.1663011970@sss.pgh.pa.us>
<87v8psl5d8.fsf@wibble.ilmari.org>
=?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= <ilmari@ilmari.org> writes:
> Git can detect more complicated code movement (see the `--color-moved`
> option to `git diff`), but I'm not sure it's clever enough to realise
> that a change modifying a block of code that was moved in the meanwhile
> should be applied at the new destination.
Yeah, I suspect people will have to manually reapply any changes in
the GUC tables to guc_tables.c. That'll be the same amount of work
for them whenever we commit this patch (unless theirs lands first,
in which case I have to deal with it). The issue I think is
whether it's politer to make that happen during a CF or between
CFs.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, ilmari@ilmari.org, andres@anarazel.de, michael@paquier.xyz, pgsql-hackers@lists.postgresql.org
Subject: Re: Splitting up guc.c
In-Reply-To: <1778776.1663014026@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox