From: Tom Lane <tgl@sss.pgh.pa.us>
To: Victor Wagner <vitus@wagner.pp.ru>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Non-portable shell code in pg_upgrade tap tests
Date: Fri, 20 Jul 2018 10:25:47 -0400
Message-ID: <17833.1532096747@sss.pgh.pa.us> (raw)
In-Reply-To: <20180720153820.69e9ae6c@fafnir.local.vm>
References: <20180720153820.69e9ae6c@fafnir.local.vm>
Victor Wagner <vitus@wagner.pp.ru> writes:
> I've discovered that in the branch REL_11_STABLE there is shell script
> src/bin/pg_upgrade/test.sh which doesn't work under Solaris 10.
> (it uses $(command) syntax with is not compatible with original
> Solaris /bin/sh)
OK ...
> It is quite easy to replace $() syntax with backticks. Backticks are
> not nestable and considered unsafe by modern shell scripting style
> guides, but they do work with older shells.
Please send a patch. Most of us do not have access to old shells
we could test this on. (The oldest machine I have, and it's old
enough to vote, does run that script ... I doubt very many other
developers have anything older.)
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, vitus@wagner.pp.ru
Subject: Re: Non-portable shell code in pg_upgrade tap tests
In-Reply-To: <17833.1532096747@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox