pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Noah Misch <noah@leadboat.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Victor Wagner <vitus@wagner.pp.ru>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Non-portable shell code in pg_upgrade tap tests
Date: Mon, 23 Jul 2018 00:00:54 -0700
Message-ID: <20180723070054.GF3998719@rfd.leadboat.com> (raw)
In-Reply-To: <24717.1532285631@sss.pgh.pa.us>
References: <20180720153820.69e9ae6c@fafnir.local.vm>
	<17833.1532096747@sss.pgh.pa.us>
	<20180720175508.07776219@fafnir.local.vm>
	<20015.1532099353@sss.pgh.pa.us>
	<20180722072904.GA3951499@rfd.leadboat.com>
	<6519.1532270763@sss.pgh.pa.us>
	<20180722173857.GA3998719@rfd.leadboat.com>
	<24717.1532285631@sss.pgh.pa.us>

On Sun, Jul 22, 2018 at 02:53:51PM -0400, Tom Lane wrote:
> Noah Misch <noah@leadboat.com> writes:
> > On Sun, Jul 22, 2018 at 10:46:03AM -0400, Tom Lane wrote:
> >> The pg_upgrade makefile does in fact use $(SHELL), so it will default to
> >> whatever shell configure used.
> 
> > It will not, because we don't set $(SHELL) anywhere.  $(SHELL) is not @SHELL@.
> > In our makefiles, $(SHELL) is always /bin/sh, the GNU make default.
> 
> Oh!  Hm, I wonder whether we shouldn't do that, ie add SHELL = @SHELL@
> to Makefile.global.in.

I see that as the right way forward.




view thread (17+ messages)

Message-ID: <20180723070054.GF3998719@rfd.leadboat.com>
Permalink:  ../20180723070054.GF3998719@rfd.leadboat.com/
Also on:    postgresql.org/message-id/20180723070054.GF3998719@rfd.leadboat.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: noah@leadboat.com, tgl@sss.pgh.pa.us, vitus@wagner.pp.ru
  Subject: Re: Non-portable shell code in pg_upgrade tap tests
  In-Reply-To: <20180723070054.GF3998719@rfd.leadboat.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox