pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: Mark Dilger <hornschnorter@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: pgsql-hackers@postgreSQL.org
Subject: Re: WIP: BRIN multi-range indexes
Date: Thu, 01 Mar 2018 23:08:06 -0500
Message-ID: <18526.1519963686@sss.pgh.pa.us> (raw)
In-Reply-To: <20180302035538.gkqgtcv6kmn2cklw@alap3.anarazel.de>
References: <20180123200537.gfx5hxcp5k5hktpe@alvherre.pgsql>
	<821c4c1d-592e-8916-e323-04607b11777e@2ndquadrant.com>
	<c32f9f46-e0ca-0c02-45ec-718dd381f4be@2ndquadrant.com>
	<104E8BB8-35FF-4AA8-9871-6AFF04E4CAF3@gmail.com>
	<0afde2fc-e160-004f-8fe2-c65302ac3760@2ndquadrant.com>
	<22674.1517874015@sss.pgh.pa.us>
	<3e924a4c-6ca0-cc10-aebb-5004fc002800@2ndquadrant.com>
	<c2523129-a970-97f2-4705-a3b65e21b32f@2ndquadrant.com>
	<20180302035538.gkqgtcv6kmn2cklw@alap3.anarazel.de>

Andres Freund <andres@anarazel.de> writes:
> On 2018-02-25 01:30:47 +0100, Tomas Vondra wrote:
>> Note: Currently, this only works with float8-based data types.
>> Supporting additional data types is not a big issue, but will
>> require extending the opclass with "subtract" operator (used to
>> compute distance between values when merging ranges).

> Based on Tom's past stances I'm a bit doubtful he'd be happy with such a
> restriction.  Note that something similar-ish also has come up in
> 0a459cec96.

> I kinda wonder if there's any way to not have two similar but not equal
> types of logic here?

Hm.  I wonder what the patch intends to do with subtraction overflow,
or infinities, or NaNs.  Just as with the RANGE patch, it does not
seem to me that failure is really an acceptable option.  Indexes are
supposed to be able to index whatever the column datatype can store.

			regards, tom lane




view thread (177+ messages)  latest in thread

Message-ID: <18526.1519963686@sss.pgh.pa.us>
Permalink:  ../18526.1519963686@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/18526.1519963686@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, tomas.vondra@2ndquadrant.com, hornschnorter@gmail.com, alvherre@alvh.no-ip.org
  Subject: Re: WIP: BRIN multi-range indexes
  In-Reply-To: <18526.1519963686@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox