From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Bruce Momjian <bruce@momjian.us>
Cc: Nathan Bossart <nathandbossart@gmail.com>
Cc: Magnus Hagander <magnus@hagander.net>
Cc: Corey Huinker <corey.huinker@gmail.com>
Cc: Jeff Davis <pgsql@j-davis.com>
Cc: jian he <jian.universality@gmail.com>
Cc: Matthias van de Meent <boekewurm+postgres@gmail.com>
Cc: Stephen Frost <sfrost@snowman.net>
Cc: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Cc: Peter Smith <smithpb2250@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Statistics Import and Export
Date: Wed, 27 Nov 2024 11:44:25 -0500
Message-ID: <1869337.1732725865@sss.pgh.pa.us> (raw)
In-Reply-To: <202411271557.gaewckwu64dm@alvherre.pgsql>
References: <202411271557.gaewckwu64dm@alvherre.pgsql>
Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> On 2024-Nov-27, Bruce Momjian wrote:
>> Would there be a default?
> There would be no default. Running with no option given would raise an
> error. The point is: you want to break scripts currently running
> --analyze-in-stages so that they can make a choice of which of these two
> modes to run. Your proposal (as I understand it) is to remove the
> --analyze-in-stages option and add two other options. My proposal is to
> keep --analyze-in-stages, but require it to have a specifier of which
> mode to run. Both achieve what you want, but I think mine achieves it
> in a cleaner way.
I do not like the idea of breaking existing upgrade scripts,
especially not by requiring them to use a parameter that older
vacuumdb versions will reject. That makes it impossible to have a
script that is version independent. I really doubt that there is any
usability improvement to be had here that's worth that.
How about causing "--analyze-in-stages" (as currently spelled) to
be a no-op? We could keep the behavior available under some other
name.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, alvherre@alvh.no-ip.org, bruce@momjian.us, nathandbossart@gmail.com, magnus@hagander.net, corey.huinker@gmail.com, pgsql@j-davis.com, jian.universality@gmail.com, boekewurm+postgres@gmail.com, sfrost@snowman.net, ashutosh.bapat.oss@gmail.com, smithpb2250@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Statistics Import and Export
In-Reply-To: <1869337.1732725865@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox