pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Mark Dilger <mark.dilger@enterprisedb.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Simon Riggs <simon.riggs@enterprisedb.com>
Subject: Re: logical replication of truncate command with trigger causes Assert
Date: Fri, 11 Jun 2021 11:26:41 -0400
Message-ID: <1882577.1623425201@sss.pgh.pa.us> (raw)
In-Reply-To: <CAA4eK1+n=4pQXKVDMO6QG7kL2QUxgeV2cq3m8_CNd_Q3Vu73iA@mail.gmail.com>
References: <B4A3AF82-79ED-4F4C-A4E5-CD2622098972@enterprisedb.com>
	<1250962.1623192946@sss.pgh.pa.us>
	<CBED95D4-5072-4A16-9271-72AB73478817@enterprisedb.com>
	<1254157.1623196736@sss.pgh.pa.us>
	<CAA4eK1+DgDdrcxQkB7s-_PmReJB7HiaFrU2PyCzqGStOwiCVPA@mail.gmail.com>
	<1356183.1623250358@sss.pgh.pa.us>
	<C6BE98EB-158D-4130-9E1C-C3DCFAE0A023@enterprisedb.com>
	<CAA4eK1L_Bw_itqBxCBW26z5SD6ru_gNWO1Xa1CTG3Jzog0sGxg@mail.gmail.com>
	<1719083.1623351052@sss.pgh.pa.us>
	<CAA4eK1+n=4pQXKVDMO6QG7kL2QUxgeV2cq3m8_CNd_Q3Vu73iA@mail.gmail.com>

Amit Kapila <amit.kapila16@gmail.com> writes:
> On Fri, Jun 11, 2021 at 12:20 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Another thing
>> I'm wondering is how many of these messages really need to be
>> translated.  We could use errmsg_internal and avoid burdening the
>> translators, perhaps.

> Not sure but I see all existing similar ereport calls don't use errmsg_internal.

I was thinking maybe we could mark all these replication protocol
violation errors non-translatable.  While we don't want to crash on a
protocol violation, it shouldn't really be a user-facing case either.
Thoughts?

			regards, tom lane





view thread (15+ messages)  latest in thread

Message-ID: <1882577.1623425201@sss.pgh.pa.us>
Permalink:  ../1882577.1623425201@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/1882577.1623425201@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, amit.kapila16@gmail.com, mark.dilger@enterprisedb.com, pgsql-hackers@lists.postgresql.org, peter.eisentraut@enterprisedb.com, simon.riggs@enterprisedb.com
  Subject: Re: logical replication of truncate command with trigger causes Assert
  In-Reply-To: <1882577.1623425201@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox