pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Peter Geoghegan <pg@bowt.ie>
To: Anastasia Lubennikova <a.lubennikova@postgrespro.ru>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Юрий Соколов <funny.falcon@gmail.com>
Subject: Re: [HACKERS] [WIP] Effective storage of duplicates in B-tree index.
Date: Thu, 27 Feb 2020 15:03:07 +0900
Message-ID: <18f07ae8-7d89-537c-b0a9-54100a1b46da@oss.nttdata.com> (raw)
In-Reply-To: <CAH2-Wznj6-cY3y=U01oRD4agHDopBfCCcEsWLeu-ojoyPsoPag@mail.gmail.com>
References: <55E4051B.7020209@postgrespro.ru>
	<5b5a470b-89d7-7177-29c2-2f907f3f441a@iki.fi>
	<CAH2-WzmZGO-NpSCu33tsoZcOskS8UbTUdd7e9V2kJA-kDusWaA@mail.gmail.com>
	<CAH2-Wz=aAMARy08hrzN9UOE4AegsAkge+0nsYk+no2S14W2g2Q@mail.gmail.com>
	<CAH2-Wz=Tr6mxMsKRmv_=9-05_O9QWqOzQ8GweRV2DXS6+Y38QQ@mail.gmail.com>
	<CAH2-Wzme6NA70bkHK=Jrjx+bkHr9DAj9gX+y5OpmvEVNy0eqVQ@mail.gmail.com>
	<CAH2-Wzk42XV2Dg4tYGsLV2X0hf8PSLZ=9gOTOSnp+d6QB_nTyA@mail.gmail.com>
	<CAH2-WzmQGYDDoAETGhpGtJQRv_uFHMjvQZ6JdLV-sxGoCgLBNg@mail.gmail.com>
	<ed6caece-5a64-ad02-2134-1e71fb4b35a1@postgrespro.ru>
	<CAH2-Wzk2p_9i7i-s22zVGdJyExaneNCcrwH4BtEDZqr73D6v_A@mail.gmail.com>
	<ed918743-bf32-b8af-0620-e07c1d81ce2f@postgrespro.ru>
	<CAH2-Wzk8aMGF6ficoKZigjwGw07hPtXdvZjPCrms_tT8GKzG=A@mail.gmail.com>
	<CAH2-Wz=_wt8D4v-1=MfhvWiyevrk+esWgE51tTnBpsOVDwN9Kw@mail.gmail.com>
	<CAH2-Wzmo_zPCs+xC=bWw7SYUtFKXV_uzCjyo-TMp+uWNXghtUQ@mail.gmail.com>
	<CAH2-Wznj6-cY3y=U01oRD4agHDopBfCCcEsWLeu-ojoyPsoPag@mail.gmail.com>



On 2020/02/27 7:43, Peter Geoghegan wrote:
> On Mon, Feb 24, 2020 at 4:54 PM Peter Geoghegan <pg@bowt.ie> wrote:
>> Attached is v34, which has this change. My plan is to commit something
>> very close to this on Wednesday morning (barring any objections).
> 
> Pushed.

Thanks for committing this nice feature!

Here is one minor comment.

+      <primary><varname>deduplicate_items</varname></primary>
+      <secondary>storage parameter</secondary>

This should be

     <primary><varname>deduplicate_items</varname> storage parameter</primary>

<secondary> for reloption is necessary only when the GUC parameter
with the same name of the reloption exists. So, for example, you can
see that <secondary> is used in vacuum_cleanup_index_scale_factor
but not in buffering reloption.

Regards,

-- 
Fujii Masao
NTT DATA CORPORATION
Advanced Platform Technology Group
Research and Development Headquarters





view thread (145+ messages)  latest in thread

Message-ID: <18f07ae8-7d89-537c-b0a9-54100a1b46da@oss.nttdata.com>
Permalink:  ../18f07ae8-7d89-537c-b0a9-54100a1b46da@oss.nttdata.com/
Also on:    postgresql.org/message-id/18f07ae8-7d89-537c-b0a9-54100a1b46da@oss.nttdata.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: masao.fujii@oss.nttdata.com, pg@bowt.ie, a.lubennikova@postgrespro.ru, hlinnaka@iki.fi, pgsql-hackers@lists.postgresql.org, funny.falcon@gmail.com
  Subject: Re: [HACKERS] [WIP] Effective storage of duplicates in B-tree index.
  In-Reply-To: <18f07ae8-7d89-537c-b0a9-54100a1b46da@oss.nttdata.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox