pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Nikita Glukhov <n.gluhov@postgrespro.ru>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Dmitry Belyavsky <beldmit@gmail.com>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Nikolay Shaplov <dhyan@nataraj.su>
Subject: Re: Ltree syntax improvement
Date: Thu, 02 Apr 2020 12:16:03 -0400
Message-ID: <19151.1585844163@sss.pgh.pa.us> (raw)
In-Reply-To: <ef4ae519-2b65-c7f0-00d2-3dffe6d04f0d@postgrespro.ru>
References: <CADqLbzLS1dy9TARVBYR=E+HUwjrAqZAoakFp_vTKWFJK=XF3Rg@mail.gmail.com>
	<20190708203303.GA17993@alvherre.pgsql>
	<CADqLbzKZ0jEEiV2mvFs3LfjfghGX9-goybbFVgUNGyqDu=rg4w@mail.gmail.com>
	<CA+hUKG+G7fP-t43ptqkBw9aW2zQuazN2g_U9yCX6dN9E65u4tw@mail.gmail.com>
	<CADqLbzKCh2e-nOyAtCX4GqW+HbwD4yX=wuOMMRFGtRYWgcnMeg@mail.gmail.com>
	<f2aa520a-f987-e03d-33cc-8aac52511332@postgrespro.ru>
	<CA+hUKGLMS_bjeT1T7g5wT+rJQb8EUcW0HDtUbCueXTmBJ9Z9UA@mail.gmail.com>
	<20200106134933.u2rblkj7ec4jky6u@development>
	<CADqLbzKRP0Dgb4oYKAE1za=7aKiATiyKrsGZ0AAVq9GE5H=eBg@mail.gmail.com>
	<31385.1579634002@sss.pgh.pa.us>
	<38c5bbeb-c3eb-a016-0b8f-907461bbd0fc@postgrespro.ru>
	<14141.1585091295@sss.pgh.pa.us>
	<a066844c-5546-b9fe-c776-bf17bd26bf82@postgrespro.ru>
	<8570.1585784810@sss.pgh.pa.us>
	<ef4ae519-2b65-c7f0-00d2-3dffe6d04f0d@postgrespro.ru>

Nikita Glukhov <n.gluhov@postgrespro.ru> writes:
> Rebased patch attached.

Thanks for rebasing!  The cfbot's not very happy though:

4842ltxtquery_io.c: In function ‘makepol’:
4843ltxtquery_io.c:188:13: error: ‘escaped’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
4844  if (lenval - escaped <= 0)
4845             ^
4846ltxtquery_io.c:230:6: note: ‘escaped’ was declared here
4847  int   escaped;
4848      ^
4849cc1: all warnings being treated as errors

			regards, tom lane





view thread (33+ messages)  latest in thread

Message-ID: <19151.1585844163@sss.pgh.pa.us>
Permalink:  ../19151.1585844163@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/19151.1585844163@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, n.gluhov@postgrespro.ru, pgsql-hackers@lists.postgresql.org, beldmit@gmail.com, tomas.vondra@2ndquadrant.com, thomas.munro@gmail.com, alvherre@2ndquadrant.com, dhyan@nataraj.su
  Subject: Re: Ltree syntax improvement
  In-Reply-To: <19151.1585844163@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox