pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers@postgresql.org, Thomas Munro <thomas.munro@gmail.com>
Subject: Re: failures in t/031_recovery_conflict.pl on CI
Date: Tue, 03 May 2022 01:16:46 -0400
Message-ID: <1959496.1651555006@sss.pgh.pa.us> (raw)
In-Reply-To: <20220503040557.eimbfibv4rsey3s5@alap3.anarazel.de>
References: <20220409231002.mddrr7mtca7p55v5@alap3.anarazel.de>
	<20220409233107.v7okovwr46xsizfk@alap3.anarazel.de>
	<5111.1649547266@sss.pgh.pa.us>
	<20220412184913.3wrt4olkdiqvicsj@alap3.anarazel.de>
	<907760.1649790322@sss.pgh.pa.us>
	<20220413002626.udl7lll7f3o7nre7@alap3.anarazel.de>
	<20220429200809.uuuseakmhb57sppk@alap3.anarazel.de>
	<465685.1651274819@sss.pgh.pa.us>
	<20220503014803.uknu3cwahwhbgrak@alap3.anarazel.de>
	<1929823.1651549472@sss.pgh.pa.us>
	<20220503040557.eimbfibv4rsey3s5@alap3.anarazel.de>

Andres Freund <andres@anarazel.de> writes:
> On 2022-05-02 23:44:32 -0400, Tom Lane wrote:
>> I can poke into that tomorrow, but are you sure that that isn't an
>> expectable result?

> It's not expected. But I think I might see what the problem is:
> We wait for the FETCH (and thus the buffer pin to be acquired). But that
> doesn't guarantee that the lock has been acquired. We can't check that with
> pump_until() afaics, because there'll not be any output. But a query_until()
> checking pg_locks should do the trick?

Irritatingly, it doesn't reproduce (at least not easily) in a manual
build on the same box.  So it's almost surely a timing issue, and
your theory here seems plausible.

			regards, tom lane





view thread (38+ messages)  latest in thread

Message-ID: <1959496.1651555006@sss.pgh.pa.us>
Permalink:  ../1959496.1651555006@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/1959496.1651555006@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, robertmhaas@gmail.com, thomas.munro@gmail.com
  Subject: Re: failures in t/031_recovery_conflict.pl on CI
  In-Reply-To: <1959496.1651555006@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox