pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers@postgresql.org, Thomas Munro <thomas.munro@gmail.com>
Subject: Re: failures in t/031_recovery_conflict.pl on CI
Date: Fri, 29 Apr 2022 19:26:59 -0400
Message-ID: <465685.1651274819@sss.pgh.pa.us> (raw)
In-Reply-To: <20220429200809.uuuseakmhb57sppk@alap3.anarazel.de>
References: <20220409045515.35ypjzddp25v72ou@alap3.anarazel.de>
	<20220409050501.frejv2i46m54keem@alap3.anarazel.de>
	<20220409220054.fqn5arvbeesmxdg5@alap3.anarazel.de>
	<20220409231002.mddrr7mtca7p55v5@alap3.anarazel.de>
	<20220409233107.v7okovwr46xsizfk@alap3.anarazel.de>
	<5111.1649547266@sss.pgh.pa.us>
	<20220412184913.3wrt4olkdiqvicsj@alap3.anarazel.de>
	<907760.1649790322@sss.pgh.pa.us>
	<20220413002626.udl7lll7f3o7nre7@alap3.anarazel.de>
	<20220429200809.uuuseakmhb57sppk@alap3.anarazel.de>

Andres Freund <andres@anarazel.de> writes:
> Questions:
> - I'm planning to backpatch the test as 031_recovery_conflict.pl, even though
>   preceding numbers are unused. It seems way more problematic to use a
>   different number in the backbranches than have gaps?

+1

> - The test uses pump_until() and wait_for_log(), which don't exist in the
>   backbranches. For now I've just inlined the implementation, but I guess we
>   could also backpatch their introduction?

I'd backpatch --- seems unlikely this will be the last need for 'em.

> pgindent uses some crazy formatting nearby:
>         SendRecoveryConflictWithBufferPin(
>                                           PROCSIG_RECOVERY_CONFLICT_STARTUP_DEADLOCK);

I do not believe that that line break is pgindent's fault.
If you just fold it into one line it should stay that way.

			regards, tom lane





view thread (38+ messages)  latest in thread

Message-ID: <465685.1651274819@sss.pgh.pa.us>
Permalink:  ../465685.1651274819@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/465685.1651274819@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, robertmhaas@gmail.com, thomas.munro@gmail.com
  Subject: Re: failures in t/031_recovery_conflict.pl on CI
  In-Reply-To: <465685.1651274819@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox