From: Andrey Lepikhov <a.lepikhov@postgrespro.ru>
To: Michael Paquier <michael@paquier.xyz>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Cc: Drouvot, Bertrand <bdrouvot@amazon.com>
Cc: Jonathan S. Katz <jkatz@postgresql.org>
Subject: Re: Generating code for query jumbling through gen_node_support.pl
Date: Tue, 11 Jul 2023 13:44:39 +0700
Message-ID: <1b92140d-ff31-21cb-3c06-e155471b87ac@postgrespro.ru> (raw)
In-Reply-To: <ZKzqO9wXJRe0FW5P@paquier.xyz>
References: <Y8oaA5Vxnr4rzEDJ@paquier.xyz>
<e4d61d52-4992-d190-b5ad-48c6c752942c@enterprisedb.com>
<Y8tdmPlzFyNcrPR3@paquier.xyz>
<bf604c8d-b6e9-284b-327a-cac8417a74e8@enterprisedb.com>
<Y8+BdCOjxykre5es@paquier.xyz>
<9695f035-0f2b-92b9-deed-0b7e5bb7e4e0@enterprisedb.com>
<Y9M+C2obzgRnXPNd@paquier.xyz>
<268fd337-8bb7-92e6-0da2-416c022c11f3@enterprisedb.com>
<ZKyHv2qN2jrZMaWO@paquier.xyz>
<5bcbf926-3d5a-e953-79a6-b6ab0f8b23a0@postgrespro.ru>
<ZKzqO9wXJRe0FW5P@paquier.xyz>
On 11/7/2023 12:35, Michael Paquier wrote:
> On Tue, Jul 11, 2023 at 12:29:29PM +0700, Andrey Lepikhov wrote:
>> I vote for only one method based on a query tree structure.
>
> Noted
>
>> BTW, did you think about different algorithms of queryId generation?
>
> Not really, except if you are referring to the possibility of being
> able to handle differently different portions of the nodes depending
> on a context given by the callers willing to do a query jumbling
> computation. (For example, choose to *not* silence the Const nodes,
> etc.)
Yes, I have two requests on different queryId algorithms:
1. With suppressed Const nodes.
2. With replacement of Oids with full names - to give a chance to see
the same queryId at different instances for the same query.
It is quite trivial to implement, but not easy in support.
>
>> Auto-generated queryId code can open a way for extensions to have
>> easy-supporting custom queryIds.
>
> Extensions can control that at some extent, already.
> --
> Michael
--
regards,
Andrey Lepikhov
Postgres Professional
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: a.lepikhov@postgrespro.ru, michael@paquier.xyz, peter.eisentraut@enterprisedb.com, pgsql-hackers@lists.postgresql.org, bdrouvot@amazon.com, jkatz@postgresql.org
Subject: Re: Generating code for query jumbling through gen_node_support.pl
In-Reply-To: <1b92140d-ff31-21cb-3c06-e155471b87ac@postgrespro.ru>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox